8310265: (process) jspawnhelper should not use argv[0]

[luhenry]

That patch makes sure that launching processes from Java works when running using Qemu user-space emulation. See
https://mail.openjdk.org/pipermail/core-libs-dev/2023-June/107738.html for details of the bug.

The backport doesn't apply cleanly.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8310265 needs maintainer approval

Issue

• JDK-8310265: (process) jspawnhelper should not use argv[0] (Bug - P3)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/384/head:pull/384
$ git checkout pull/384

Update a local copy of the PR:
$ git checkout pull/384
$ git pull https://git.openjdk.org/jdk17u.git pull/384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 384

View PR using the GUI difftool:
$ git pr show -t 384

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/384.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back luhenry! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[luhenry]

I followed the guide at openjdk/jdk#14531 (comment). Please let me know if I missed anything.

In relation with https://bugs.openjdk.org/browse/JDK-8310265

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (8bb00ecc)

[tstuefe]

Okay.

Merge conflicts due to https://bugs.openjdk.org/browse/JDK-8307990. May be valuable to downport too, but I it would be a lot more work, at least review wise.

[openjdk]

⚠️ @luhenry This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[luhenry]

/approval request

[openjdk]

@luhenry
8310265: The approval request has been created successfully.

[tstuefe]

@luhenry Odd. The request in JBS is marked with "critical". Is this critical or is this a Skara glitch?

[luhenry]

I haven't marked it as critical, so maybe a skara glitch. Happy to change the tag if you prefer.

[tstuefe]

Done :)

[zhaosongzs]

@luhenry Odd. The request in JBS is marked with "critical". Is this critical or is this a Skara glitch?

I don't think it's a skara issue. That's what the maintainer requested. See https://bugs.openjdk.org/browse/SKARA-2075

[luhenry]

Let's keep the jdk17u-fix-request, it's not a critical issue.

[GoeLin]

Hi @luhenry,
it is marked as critical as you are targeting jdk17u.
Please close this PR and open it again aginst jdk17u-dev.
also, in your approval command, give a text that lists reason, risk, testing and whether it is a clean backport. The command copies all multi-line text into the comment in the JBS issue.
Also, please enable pre-submit tests for this repo and potentially jdk17u-dev if you have not yet done so.

[GoeLin]

/approve no
Wrong repo.

[openjdk]

@GoeLin
8310265: There is no maintainer approval request for this issue.

[tstuefe]

/approve no Wrong repo.

Argh, I completely missed that, sorry. Also that explains the "critical".

[luhenry]

I will resubmit the PR to the right repo, sorry for the noise.