Skip to content

8272903: Missing license header in ArenaAllocator.java#388

Closed
offamitkumar wants to merge 2 commits intoopenjdk:masterfrom
openjdk-bots:backport-offamitkumar-96614da0
Closed

8272903: Missing license header in ArenaAllocator.java#388
offamitkumar wants to merge 2 commits intoopenjdk:masterfrom
openjdk-bots:backport-offamitkumar-96614da0

Conversation

@offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Feb 27, 2024

Hi all,

This pull request contains a backport of commit 96614da0 from the openjdk/jdk repository.

The commit being backported was authored by Maurizio Cimadamore on 9 Sep 2021 and was reviewed by Brian Burkhalter and Lance Andersen.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8272903 needs maintainer approval

Issue

  • JDK-8272903: Missing license header in ArenaAllocator.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/388/head:pull/388
$ git checkout pull/388

Update a local copy of the PR:
$ git checkout pull/388
$ git pull https://git.openjdk.org/jdk17u.git pull/388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 388

View PR using the GUI difftool:
$ git pr show -t 388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/388.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 96614da0254e7fd4ac9dd3c3059bf23c1aaf37ff 8272903: Missing license header in ArenaAllocator.java Feb 27, 2024
@openjdk
Copy link

openjdk bot commented Feb 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 27, 2024
@openjdk
Copy link

openjdk bot commented Feb 27, 2024

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 27, 2024
@offamitkumar
Copy link
Member Author

/approval request Header was missing in JDK-17 and JDK-18 original PR added for JDK-18 but not backported to JDK-17.

@mlbridge
Copy link

mlbridge bot commented Feb 27, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 27, 2024

@offamitkumar
8272903: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 27, 2024
@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Feb 28, 2024
@offamitkumar
Copy link
Member Author

@GoeLin Would you please review this PR.

@offamitkumar
Copy link
Member Author

@mcimadamore would you help me in integrating this one, if you have bandwidth.

@RealCLanger
Copy link
Contributor

@offamitkumar Is there any reason why this needs to be done in rampdown jdk17u repository? I guess jdk17u-dev would be more appropriate.

Also, for the backport, please don't add the copyright year 2024. Then it would apply cleanly and no formal PR review would be necessary. Thanks.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Mar 1, 2024
@offamitkumar
Copy link
Member Author

@RealCLanger do we need to create separate PR manually for that or we can just use backport command like "/backport jdk17u-dev" ?

@jerboaa
Copy link
Contributor

jerboaa commented Mar 1, 2024

or we can just use backport command like "/backport jdk17u-dev" ?

Yes, that should work. Please close this and use a PR for jdk17u-dev instead.

@offamitkumar
Copy link
Member Author

Thanks @jerboaa ;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants