Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270344: Session resumption errors #39

Closed
wants to merge 1 commit into from

Conversation

coffeys
Copy link
Contributor

@coffeys coffeys commented Aug 24, 2021

Clean backport to JDK 17 Updates


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/39/head:pull/39
$ git checkout pull/39

Update a local copy of the PR:
$ git checkout pull/39
$ git pull https://git.openjdk.java.net/jdk17u pull/39/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 39

View PR using the GUI difftool:
$ git pr show -t 39

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/39.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2021

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 04a806ec86a388b8de31d42f904c4321beb69e14 8270344: Session resumption errors Aug 24, 2021
@openjdk
Copy link

openjdk bot commented Aug 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 24, 2021

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270344: Session resumption errors

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 648f3f6: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848
  • 9a7046d: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup
  • bb7c412: 8272472: StackGuardPages test doesn't build with glibc 2.34

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2021

Webrevs

@coffeys
Copy link
Contributor Author

coffeys commented Aug 25, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2021

Going to push as commit 20d00eb.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 37de147: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible
  • 648f3f6: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848
  • 9a7046d: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup
  • bb7c412: 8272472: StackGuardPages test doesn't build with glibc 2.34

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2021
@openjdk
Copy link

openjdk bot commented Aug 25, 2021

@coffeys Pushed as commit 20d00eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant