-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods #394
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for backporting!
|
Thanks for review and approval! |
/integrate |
Going to push as commit 897f433. |
A backport to jdk17u as this fixes a jck issue. Based on the commit to 21.
The change of 21 does not apply clean:
src/hotspot/share/services/classLoadingService.cpp
Copyright
src/hotspot/share/services/classLoadingService.hpp
Resolved due to context
src/hotspot/share/services/memoryService.cpp
Copyright
To make it compile, I had to adapt StdoutLog again,
as "8293873: Centralize the initialization of UL" is not in 17.
See extra commit.
The new tests pass and fail as expected without the fix.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/394/head:pull/394
$ git checkout pull/394
Update a local copy of the PR:
$ git checkout pull/394
$ git pull https://git.openjdk.org/jdk17u.git pull/394/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 394
View PR using the GUI difftool:
$ git pr show -t 394
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/394.diff
Webrev
Link to Webrev Comment