Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print" #4

Closed
wants to merge 1 commit into from
Closed

8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print" #4

wants to merge 1 commit into from

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 19, 2021

Hi all,

this pull request contains a backport of commit c0b4407d from the openjdk/jdk repository.

The commit being backported was authored by Anton Litvinov on 14 Jun 2021 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.java.net/jdk17u pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/4.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 19, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport c0b4407d09a7bf9f15553dc5344b1e354b150d57 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print" Jul 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jul 19, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

Going to push as commit d684356.

Loading

@openjdk openjdk bot closed this Jul 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@RealCLanger Pushed as commit d684356.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 19, 2021

Webrevs

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant