Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java #40

Closed
wants to merge 1 commit into from

Conversation

akolarkunnu
Copy link
Contributor

@akolarkunnu akolarkunnu commented Aug 25, 2021

Test Result - https://mach5.us.oracle.com/mdash/jobs/akolarku-jdk17u-cpu-20210825-0713-24028774


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/40/head:pull/40
$ git checkout pull/40

Update a local copy of the PR:
$ git checkout pull/40
$ git pull https://git.openjdk.java.net/jdk17u pull/40/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 40

View PR using the GUI difftool:
$ git pr show -t 40

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/40.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2021

👋 Welcome back akolarkunnu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ed57cf1cf3f2d107e085ecdae38a63e66ab2fa30 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java Aug 25, 2021
@openjdk
Copy link

openjdk bot commented Aug 25, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 25, 2021

@akolarkunnu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2021

Webrevs

@akolarkunnu
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2021

Going to push as commit 9248bd0.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 671dab6: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status
  • 71a6aae: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
  • 20d00eb: 8270344: Session resumption errors

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2021
@openjdk
Copy link

openjdk bot commented Aug 26, 2021

@akolarkunnu Pushed as commit 9248bd0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant