Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8195675: Call to insertText with single character from custom Input Method ignored #403

Closed

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 16, 2024

Hi all,

This pull request contains a backport of commit b8f2ec90 openjdk/jdk#17921 from the openjdk/jdk repository.

The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8195675 needs maintainer approval

Issue

  • JDK-8195675: Call to insertText with single character from custom Input Method ignored (Bug - P4 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/403/head:pull/403
$ git checkout pull/403

Update a local copy of the PR:
$ git checkout pull/403
$ git pull https://git.openjdk.org/jdk17u.git pull/403/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 403

View PR using the GUI difftool:
$ git pr show -t 403

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/403.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2024

👋 Welcome back srl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd 8195675: Call to insertText with single character from custom Input Method ignored Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 16, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2024

Webrevs

@srl295
Copy link
Member Author

srl295 commented Oct 16, 2024

sorry, i incorrectly kept the Kotoeri check ,that's now removed so it should match the original commit.

@srl295 srl295 force-pushed the backport-srl295-b8f2ec90-master branch from 6482fa7 to 8247318 Compare October 16, 2024 20:00
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@srl295 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean label Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

⚠️ @srl295 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@srl295
Copy link
Member Author

srl295 commented Oct 16, 2024

/approval

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@srl295 usage: /approval [<id>] (request|cancel) [<text>]

@srl295
Copy link
Member Author

srl295 commented Oct 16, 2024

/approval request java.awt components did not work properly on macOS with custom input methods, the net effect is that minority language keyboards did not work properly with Java. Low risk, the fix handles this situation similarly to how Apple's own 'kotoeri' input method was handled on a long term basis, so it is a well-worn path. Patch should apply cleanly and was code reviewed

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@srl295
8195675: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 16, 2024
@GoeLin
Copy link
Member

GoeLin commented Oct 17, 2024

Hi,
first, please enable GHA testing on this repo.
Second, I think you want to target jdk17u-dev.
If we submit this here, this would mean we need to do an extra build of 17.0.13, like 17.0.13.1.
As you have not given sufficient reasoning to do so, I deny this request.

@GoeLin
Copy link
Member

GoeLin commented Oct 17, 2024

Further there is a jdk17u-fix-request, I remove that because there is no corresponding PR.

@openjdk openjdk bot removed the approval label Oct 17, 2024
@srl295
Copy link
Member Author

srl295 commented Oct 17, 2024

Hi, first, please enable GHA testing on this repo. Second, I think you want to target jdk17u-dev. If we submit this here, this would mean we need to do an extra build of 17.0.13, like 17.0.13.1. As you have not given sufficient reasoning to do so, I deny this request.

Sorry, I misunderstood, will target jdk17u-dev and fix tests

@srl295
Copy link
Member Author

srl295 commented Oct 17, 2024

incorrectly opened in jdk17u, reopened as => openjdk/jdk17u-dev#2971

@srl295 srl295 closed this Oct 17, 2024
@srl295 srl295 deleted the backport-srl295-b8f2ec90-master branch October 17, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants