8195675: Call to insertText with single character from custom Input Method ignored

[srl295]

Hi all,

This pull request contains a backport of commit b8f2ec90 openjdk/jdk#17921 from the openjdk/jdk repository.

The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8195675 needs maintainer approval

Issue

• JDK-8195675: Call to insertText with single character from custom Input Method ignored (Bug - P4 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/403/head:pull/403
$ git checkout pull/403

Update a local copy of the PR:
$ git checkout pull/403
$ git pull https://git.openjdk.org/jdk17u.git pull/403/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 403

View PR using the GUI difftool:
$ git pr show -t 403

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/403.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back srl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (8247318b)
• 00: Full (6482fa74)

[srl295]

sorry, i incorrectly kept the Kotoeri check ,that's now removed so it should match the original commit.

[openjdk]

@srl295 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

⚠️ @srl295 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[srl295]

/approval

[openjdk]

@srl295 usage: /approval [<id>] (request|cancel) [<text>]

[srl295]

/approval request java.awt components did not work properly on macOS with custom input methods, the net effect is that minority language keyboards did not work properly with Java. Low risk, the fix handles this situation similarly to how Apple's own 'kotoeri' input method was handled on a long term basis, so it is a well-worn path. Patch should apply cleanly and was code reviewed

[openjdk]

@srl295
8195675: The approval request has been created successfully.

[GoeLin]

Hi,
first, please enable GHA testing on this repo.
Second, I think you want to target jdk17u-dev.
If we submit this here, this would mean we need to do an extra build of 17.0.13, like 17.0.13.1.
As you have not given sufficient reasoning to do so, I deny this request.

[GoeLin]

Further there is a jdk17u-fix-request, I remove that because there is no corresponding PR.

[srl295]

Hi, first, please enable GHA testing on this repo. Second, I think you want to target jdk17u-dev. If we submit this here, this would mean we need to do an extra build of 17.0.13, like 17.0.13.1. As you have not given sufficient reasoning to do so, I deny this request.

Sorry, I misunderstood, will target jdk17u-dev and fix tests

[srl295]

incorrectly opened in jdk17u, reopened as => openjdk/jdk17u-dev#2971