-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021" #45
Conversation
…er 2021" This reverts commit 551354e.
👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into |
/label security |
@rhalade The label |
@seanjmullan can you please review this? |
@rhalade This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 3623ea6. |
The removal of Google's GlobalSign root was pulled into 17.0.1 which is to be released in Oct 2021. But this root doesn't expire until Dec 2021 so the fix should be backed out from 17.0.1
This reverts commit 551354e.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/45/head:pull/45
$ git checkout pull/45
Update a local copy of the PR:
$ git checkout pull/45
$ git pull https://git.openjdk.java.net/jdk17u pull/45/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 45
View PR using the GUI difftool:
$ git pr show -t 45
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/45.diff