Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021" #45

Closed
wants to merge 1 commit into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Aug 30, 2021

The removal of Google's GlobalSign root was pulled into 17.0.1 which is to be released in Oct 2021. But this root doesn't expire until Dec 2021 so the fix should be backed out from 17.0.1

This reverts commit 551354e.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/45/head:pull/45
$ git checkout pull/45

Update a local copy of the PR:
$ git checkout pull/45
$ git pull https://git.openjdk.java.net/jdk17u pull/45/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 45

View PR using the GUI difftool:
$ git pr show -t 45

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/45.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2021

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@rhalade rhalade changed the title Revert "8225083: Remove Google certificate that is expiring in December 2021" 8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021" Aug 30, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 30, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2021

Webrevs

@rhalade
Copy link
Member Author

rhalade commented Aug 30, 2021

/label security

@openjdk
Copy link

openjdk bot commented Aug 30, 2021

@rhalade The label security is not a valid label. These labels are valid:

@rhalade
Copy link
Member Author

rhalade commented Aug 31, 2021

@seanjmullan can you please review this?

@openjdk
Copy link

openjdk bot commented Aug 31, 2021

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021"

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 31, 2021
@rhalade
Copy link
Member Author

rhalade commented Sep 2, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 2, 2021

Going to push as commit 3623ea6.

@openjdk openjdk bot closed this Sep 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 2, 2021
@rhalade rhalade deleted the 8273150 branch September 2, 2021 15:42
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 2, 2021
@openjdk
Copy link

openjdk bot commented Sep 2, 2021

@rhalade Pushed as commit 3623ea6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants