Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269031: linux x86_64 check for binutils 2.25 or higher after 8265783 #46

Closed
wants to merge 1 commit into from
Closed

8269031: linux x86_64 check for binutils 2.25 or higher after 8265783 #46

wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 31, 2021

Hi all,

this pull request contains a backport of commit 18a1dd26 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 22 Jun 2021 and was reviewed by Magnus Ihse Bursie and Erik Joelsson.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269031: linux x86_64 check for binutils 2.25 or higher after 8265783

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/46/head:pull/46
$ git checkout pull/46

Update a local copy of the PR:
$ git checkout pull/46
$ git pull https://git.openjdk.java.net/jdk17u pull/46/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 46

View PR using the GUI difftool:
$ git pr show -t 46

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/46.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 31, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 18a1dd261cec6fa1c5820dce2df47d488417afff 8269031: linux x86_64 check for binutils 2.25 or higher after 8265783 Aug 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269031: linux x86_64 check for binutils 2.25 or higher after 8265783

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 103 new commits pushed to the master branch:

  • 5e04e45: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • ff6a938: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182
  • 9248bd0: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java
  • 671dab6: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status
  • 71a6aae: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
  • 20d00eb: 8270344: Session resumption errors
  • 37de147: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible
  • 648f3f6: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848
  • 9a7046d: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup
  • bb7c412: 8272472: StackGuardPages test doesn't build with glibc 2.34
  • ... and 93 more: https://git.openjdk.java.net/jdk17u/compare/9b6aa5304c4768b1200cd1f0990fee4d0e9a2600...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Aug 31, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 31, 2021

Webrevs

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Sep 9, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

Going to push as commit 271403b.
Since your change was applied there have been 106 commits pushed to the master branch:

  • e1cd6c7: 8269280: (bf) Replace StringBuffer in *Buffer.toString()
  • ad04269: 8269924: Shenandoah: Introduce weak/strong marking asserts
  • 3623ea6: 8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021"
  • 5e04e45: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • ff6a938: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182
  • 9248bd0: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java
  • 671dab6: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status
  • 71a6aae: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
  • 20d00eb: 8270344: Session resumption errors
  • 37de147: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible
  • ... and 96 more: https://git.openjdk.java.net/jdk17u/compare/9b6aa5304c4768b1200cd1f0990fee4d0e9a2600...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@MBaesken Pushed as commit 271403b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant