Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit #47

Closed
wants to merge 1 commit into from

Conversation

Larry-N
Copy link
Contributor

@Larry-N Larry-N commented Aug 31, 2021

Tested with tier1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/47/head:pull/47
$ git checkout pull/47

Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.java.net/jdk17u pull/47/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 47

View PR using the GUI difftool:
$ git pr show -t 47

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/47.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 31, 2021

👋 Welcome back Larry-N! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 31, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 31, 2021

Webrevs

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Aug 31, 2021

Thanks for doing this backport.

Did you follow this guide to prepare a backport PR?
https://wiki.openjdk.java.net/display/SKARA/Backports

@Larry-N
Copy link
Contributor Author

@Larry-N Larry-N commented Aug 31, 2021

Thanks for doing this backport.

Did you follow this guide to prepare a backport PR?
https://wiki.openjdk.java.net/display/SKARA/Backports

Yes, I referred to the wiki, and create the commit manually as described in the 'CLI' paragraph.

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Aug 31, 2021

Thanks for doing this backport.
Did you follow this guide to prepare a backport PR?
https://wiki.openjdk.java.net/display/SKARA/Backports

Yes, I referred to the wiki, and create the commit manually as described in the 'CLI' paragraph.

Please set the PR's title as Backport 1ea437a4b87381b558cf8157ac52fc03e37ac507 .
Then the robot can recognize it as a backport.
Thanks.

@Larry-N Larry-N changed the title 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit Backport 1ea437a4b87381b558cf8157ac52fc03e37ac507 Aug 31, 2021
@openjdk openjdk bot changed the title Backport 1ea437a4b87381b558cf8157ac52fc03e37ac507 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit Aug 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

@Larry-N This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 130 new commits pushed to the master branch:

  • ddb89c3: 8275131: Exceptions after a touchpad gesture on macOS
  • 01f4883: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag
  • 9751b8f: 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests
  • aabc4ba: 8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
  • e79cb9c: 8274840: Update OS detection code to recognize Windows 11
  • bbcb072: 8274407: (tz) Update Timezone Data to 2021c
  • 47c129d: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • cbd82db: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
  • 54a86bb: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 59ecf3c: 8270517: Add Zero support for LoongArch
  • ... and 120 more: https://git.openjdk.java.net/jdk17u/compare/5e04e452714742ee5cbc6e922695db9d7d56da92...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 31, 2021
@DamonFool
Copy link
Member

@DamonFool DamonFool commented Aug 31, 2021

Now it should be OK to integrate it since it has been approved.
Thanks.

@Larry-N
Copy link
Contributor Author

@Larry-N Larry-N commented Aug 31, 2021

Thank you for help.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 12, 2021

@Larry-N This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 13, 2021

Hi @Larry-N , please integrate this backport.
Thanks.

@Larry-N
Copy link
Contributor Author

@Larry-N Larry-N commented Oct 18, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@Larry-N
Your change (at version 8e0a326) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 18, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

Going to push as commit efdf411.
Since your change was applied there have been 130 commits pushed to the master branch:

  • ddb89c3: 8275131: Exceptions after a touchpad gesture on macOS
  • 01f4883: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag
  • 9751b8f: 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests
  • aabc4ba: 8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
  • e79cb9c: 8274840: Update OS detection code to recognize Windows 11
  • bbcb072: 8274407: (tz) Update Timezone Data to 2021c
  • 47c129d: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • cbd82db: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
  • 54a86bb: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 59ecf3c: 8270517: Add Zero support for LoongArch
  • ... and 120 more: https://git.openjdk.java.net/jdk17u/compare/5e04e452714742ee5cbc6e922695db9d7d56da92...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@DamonFool @Larry-N Pushed as commit efdf411.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants