Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events #5

Closed
wants to merge 1 commit into from
Closed

8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events #5

wants to merge 1 commit into from

Conversation

@reinrich
Copy link
Contributor

@reinrich reinrich commented Jul 19, 2021

Hi all,
this pull request contains a backport of commit 72530ef6 from the openjdk/jdk repository.
The commit being backported was authored by Richard Reingruber on 7 Jul 2021 and was reviewed by Vladimir Kozlov, Roland Westrelin and Nils Eliasson.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/5/head:pull/5
$ git checkout pull/5

Update a local copy of the PR:
$ git checkout pull/5
$ git pull https://git.openjdk.java.net/jdk17u pull/5/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5

View PR using the GUI difftool:
$ git pr show -t 5

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/5.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 19, 2021

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 72530ef666ce2ace899cf34faefe715539d1ee25 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events Jul 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 192 new commits pushed to the master branch:

  • 00ffb8f: 8263531: Remove unused buffer int
  • d684356: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
  • a32d2ee: 8269276: Additional tests for MessageDigest with different providers
  • 7b4d84c: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848
  • 72db09b: 8266313: (JEP-356) - RandomGenerator spec implementation requirements tightly coupled to JDK internal classes
  • 3bbd233: 8270075: SplittableRandom extends AbstractSplittableGenerator
  • 381bd62: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • 82c256e: 8259499: Handling type arguments from outer classes for inner class in javadoc
  • e5db9a9: 8268620: InfiniteLoopException test may fail on x86 platforms
  • 67273ae: 8269865: Async UL needs to handle ERANGE on exceeding SEM_VALUE_MAX
  • ... and 182 more: https://git.openjdk.java.net/jdk17u/compare/9ad19f7838e6f6e128583c191c5507c1e2bd5083...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 19, 2021

Webrevs

Loading

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Aug 3, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

Going to push as commit a575f5c.
Since your change was applied there have been 259 commits pushed to the master branch:

  • de808a5: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • afede39: Merge
  • f8fb571: 8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34)
  • e351de3: 8271272: C2: assert(!had_error) failed: bad dominance
  • 6180cf1: 8271512: ProblemList serviceability/sa/sadebugd/DebugdConnectTest.java due to 8270326
  • a1b5b81: 8271507: ProblemList SA tests that are failing with ZGC due to JDK-8248912
  • 286d313: 8271489: (doc) Clarify Filter Factory example
  • 20d2dc1: 8271403: mark hotspot runtime/memory tests which ignore external VM flags
  • e593e3d: 8271402: mark hotspot runtime/os tests which ignore external VM flags
  • 7bf72ce: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java
  • ... and 249 more: https://git.openjdk.java.net/jdk17u/compare/9ad19f7838e6f6e128583c191c5507c1e2bd5083...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@reinrich Pushed as commit a575f5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant