Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong #54

Closed
wants to merge 1 commit into from
Closed

8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong #54

wants to merge 1 commit into from

Conversation

ChrisHegarty
Copy link
Member

@ChrisHegarty ChrisHegarty commented Sep 7, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/54/head:pull/54
$ git checkout pull/54

Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.java.net/jdk17u pull/54/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 54

View PR using the GUI difftool:
$ git pr show -t 54

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/54.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2021

👋 Welcome back chegar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fe7d70886cc9985478c5810eff0790648a9aae41 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong Sep 7, 2021
@openjdk
Copy link

openjdk bot commented Sep 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 7, 2021

@ChrisHegarty This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2021

Webrevs

@ChrisHegarty
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 9, 2021

Going to push as commit 0ced2aa.
Since your change was applied there have been 4 commits pushed to the master branch:

  • ea6e678: 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"
  • 271403b: 8269031: linux x86_64 check for binutils 2.25 or higher after 8265783
  • e1cd6c7: 8269280: (bf) Replace StringBuffer in *Buffer.toString()
  • ad04269: 8269924: Shenandoah: Introduce weak/strong marking asserts

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 9, 2021
@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@ChrisHegarty Pushed as commit 0ced2aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant