Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop #55

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 8, 2021

Clean backport to fix the test.

Additional testing:

  • Eyeballed test output to see that CompilerCommand error is gone

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/55/head:pull/55
$ git checkout pull/55

Update a local copy of the PR:
$ git checkout pull/55
$ git pull https://git.openjdk.java.net/jdk17u pull/55/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 55

View PR using the GUI difftool:
$ git pr show -t 55

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/55.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9166ba37b631aa7ae641488f6167cdbd7fcdff00 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop Sep 8, 2021
@openjdk
Copy link

openjdk bot commented Sep 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 8, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • ad04269: 8269924: Shenandoah: Introduce weak/strong marking asserts
  • 3623ea6: 8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021"
  • 5e04e45: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • ff6a938: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182
  • 9248bd0: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java
  • 671dab6: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status
  • 71a6aae: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
  • 20d00eb: 8270344: Session resumption errors
  • 37de147: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 8, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Sep 9, 2021

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 9, 2021

Going to push as commit 6a7542f.
Since your change was applied there have been 17 commits pushed to the master branch:

  • f1c8fa6: 8271121: ZGC: stack overflow (segv) when -Xlog:gc+start=debug
  • d561554: 8270110: Shenandoah: Add test for JDK-8269661
  • c96cfed: 8270171: Shenandoah: Cleanup TestStringDedup and TestStringDedupStress tests
  • f32703f: 8272783: Epsilon: Refactor tests to improve performance
  • 0ced2aa: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
  • ea6e678: 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"
  • 271403b: 8269031: linux x86_64 check for binutils 2.25 or higher after 8265783
  • e1cd6c7: 8269280: (bf) Replace StringBuffer in *Buffer.toString()
  • ad04269: 8269924: Shenandoah: Introduce weak/strong marking asserts
  • 3623ea6: 8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021"
  • ... and 7 more: https://git.openjdk.java.net/jdk17u/compare/648f3f6a8fe9ea2e00b60710afa44208cfbc2c49...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 9, 2021
@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@shipilev Pushed as commit 6a7542f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8272973 branch Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant