Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine" #59

Closed
wants to merge 1 commit into from

Conversation

@thejasviv
Copy link
Member

@thejasviv thejasviv commented Sep 9, 2021

This is a straight, clean backport of:

8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"

The patch applies clean, and the test passes on all platforms post patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/59/head:pull/59
$ git checkout pull/59

Update a local copy of the PR:
$ git checkout pull/59
$ git pull https://git.openjdk.java.net/jdk17u pull/59/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 59

View PR using the GUI difftool:
$ git pr show -t 59

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/59.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 9, 2021

👋 Welcome back tvoniadka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport f18c0fac11aac833edfdc484e221518c55daa9a7 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine" Sep 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@thejasviv This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 271403b: 8269031: linux x86_64 check for binutils 2.25 or higher after 8265783

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 9, 2021

Webrevs

Loading

@sisahoo
Copy link
Member

@sisahoo sisahoo commented Sep 9, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@sisahoo The change author (@thejasviv) must issue an integrate command before the integration can be sponsored.

Loading

@thejasviv
Copy link
Member Author

@thejasviv thejasviv commented Sep 9, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Sep 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@thejasviv
Your change (at version eb0f889) is now ready to be sponsored by a Committer.

Loading

@sisahoo
Copy link
Member

@sisahoo sisahoo commented Sep 9, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

Going to push as commit ea6e678.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 271403b: 8269031: linux x86_64 check for binutils 2.25 or higher after 8265783

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@sisahoo @thejasviv Pushed as commit ea6e678.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants