Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Sep 10, 2021

Clean backport to get includes in order.

This patch should be additionally tested with GHA that builds both Linux and Windows AArch64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269687: pauth_aarch64.hpp include name is incorrect

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/64/head:pull/64
$ git checkout pull/64

Update a local copy of the PR:
$ git checkout pull/64
$ git pull https://git.openjdk.java.net/jdk17u pull/64/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 64

View PR using the GUI difftool:
$ git pr show -t 64

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/64.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b690f29699180149d33b6a83de10697790587a87 8269687: pauth_aarch64.hpp include name is incorrect Sep 10, 2021
@openjdk
Copy link

openjdk bot commented Sep 10, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 10, 2021
@openjdk
Copy link

openjdk bot commented Sep 10, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269687: pauth_aarch64.hpp include name is incorrect

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • cef269f: 8270317: Large Allocation in CipherSuite
  • 9f7de59: 8263773: Reenable German localization for builds at Oracle
  • 6a7542f: 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop
  • f1c8fa6: 8271121: ZGC: stack overflow (segv) when -Xlog:gc+start=debug
  • d561554: 8270110: Shenandoah: Add test for JDK-8269661
  • c96cfed: 8270171: Shenandoah: Cleanup TestStringDedup and TestStringDedupStress tests
  • f32703f: 8272783: Epsilon: Refactor tests to improve performance
  • 0ced2aa: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
  • ea6e678: 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"
  • 271403b: 8269031: linux x86_64 check for binutils 2.25 or higher after 8265783
  • ... and 10 more: https://git.openjdk.java.net/jdk17u/compare/648f3f6a8fe9ea2e00b60710afa44208cfbc2c49...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 10, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2021

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 14, 2021

Going to push as commit 4dff991.
Since your change was applied there have been 24 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 14, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2021
@openjdk
Copy link

openjdk bot commented Sep 14, 2021

@shipilev Pushed as commit 4dff991.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8269687 branch October 1, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant