Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272838: Move CriticalJNI tests out of tier1 #67

Closed
wants to merge 1 commit into from
Closed

8272838: Move CriticalJNI tests out of tier1 #67

wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Sep 10, 2021

Clean backport to make tests faster and prepare to potential backport of JDK-8272914.

Additional testing:

  • Linux x86_64 hotspot:tier1 does not include affected tests anymore
  • Linux x86_64 hotspot_gc_shenandoah includes affected tests
  • Linux x86_64 hotspot_gc_epsilon includes affected tests

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/67/head:pull/67
$ git checkout pull/67

Update a local copy of the PR:
$ git checkout pull/67
$ git pull https://git.openjdk.java.net/jdk17u pull/67/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 67

View PR using the GUI difftool:
$ git pr show -t 67

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/67.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 10, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk openjdk bot changed the title Backport f55d5ab5177b6e08e8499abc181a320a98b28a5f 8272838: Move CriticalJNI tests out of tier1 Sep 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272838: Move CriticalJNI tests out of tier1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • cef269f: 8270317: Large Allocation in CipherSuite
  • 9f7de59: 8263773: Reenable German localization for builds at Oracle
  • 6a7542f: 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop
  • f1c8fa6: 8271121: ZGC: stack overflow (segv) when -Xlog:gc+start=debug
  • d561554: 8270110: Shenandoah: Add test for JDK-8269661
  • c96cfed: 8270171: Shenandoah: Cleanup TestStringDedup and TestStringDedupStress tests
  • f32703f: 8272783: Epsilon: Refactor tests to improve performance
  • 0ced2aa: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
  • ea6e678: 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"
  • 271403b: 8269031: linux x86_64 check for binutils 2.25 or higher after 8265783
  • ... and 10 more: https://git.openjdk.java.net/jdk17u/compare/648f3f6a8fe9ea2e00b60710afa44208cfbc2c49...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 10, 2021

Webrevs

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 20, 2021

Got the push approval.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

Going to push as commit 759cbcb.
Since your change was applied there have been 30 commits pushed to the master branch:

  • da1c0fe: 8272639: jpackaged applications using microphone on mac
  • 20be766: 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers
  • f8ecff4: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 808356a: 8273358: macOS Monterey does not have the font Times needed by Serif
  • ec0b85a: 8273593: [REDO] Warn user when using mac-sign option with unsigned app-image.
  • 4dff991: 8269687: pauth_aarch64.hpp include name is incorrect
  • 0e847cf: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling
  • d9a7fc6: Merge
  • 4afbcaf: 8273592: Backout JDK-8271868
  • a37254c: 8271868: Warn user when using mac-sign option with unsigned app-image.
  • ... and 20 more: https://git.openjdk.java.net/jdk17u/compare/648f3f6a8fe9ea2e00b60710afa44208cfbc2c49...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@shipilev Pushed as commit 759cbcb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8272838 branch Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant