Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268893: jcmd to trim the glibc heap #70

Closed
wants to merge 1 commit into from
Closed

8268893: jcmd to trim the glibc heap #70

wants to merge 1 commit into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Sep 10, 2021

Hi,

may I please have reviews for this clean backport of 8268893: "jcmd to trim the glibc heap"?

The command turned out to be very useful to us when analyzing suspected memory leaks. It would be nice to have this in JDK 17.

The associated downport-CSR had been provisionally approved.

The patch applies cleanly.

Thank you, Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/70/head:pull/70
$ git checkout pull/70

Update a local copy of the PR:
$ git checkout pull/70
$ git pull https://git.openjdk.java.net/jdk17u pull/70/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 70

View PR using the GUI difftool:
$ git pr show -t 70

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/70.diff


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/70/head:pull/70
$ git checkout pull/70

Update a local copy of the PR:
$ git checkout pull/70
$ git pull https://git.openjdk.java.net/jdk17u pull/70/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 70

View PR using the GUI difftool:
$ git pr show -t 70

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/70.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 10, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6096dd9765eaf280890f65c0ff1ab64864b9316a 8268893: jcmd to trim the glibc heap Sep 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268893: jcmd to trim the glibc heap

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 10, 2021
@tstuefe tstuefe marked this pull request as ready for review Sep 21, 2021
@openjdk openjdk bot added the rfr label Sep 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2021

Webrevs

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Sep 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

Going to push as commit d935001.
Since your change was applied there have been 29 commits pushed to the master branch:

  • c4dfa57: 8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
  • 926a815: 8273902: Memory leak in OopStorage due to bug in OopHandle::release()
  • d46a5ae: 8274056: JavaAccessibilityUtilities leaks JNI objects
  • 7b67581: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • 00f7c45: 8273451: Remove unreachable return in mutexLocker::wait
  • 227e159: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop
  • 9d590fc: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • 8cd9319: 8274215: Remove globalsignr2ca root from 17.0.2
  • cb6a08c: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher
  • 912ae51: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions
  • ... and 19 more: https://git.openjdk.java.net/jdk17u/compare/cef269f89633331a68c9549a08d2d88d5534b8fa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@tstuefe Pushed as commit d935001.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant