Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8273593: [REDO] Warn user when using mac-sign option with unsigned app-image. #72

Closed
wants to merge 1 commit into from

Conversation

andyherrick
Copy link

@andyherrick andyherrick commented Sep 10, 2021

backport from jdk18 to jdk17u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273593: [REDO] Warn user when using mac-sign option with unsigned app-image.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/72/head:pull/72
$ git checkout pull/72

Update a local copy of the PR:
$ git checkout pull/72
$ git pull https://git.openjdk.java.net/jdk17u pull/72/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 72

View PR using the GUI difftool:
$ git pr show -t 72

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/72.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 10, 2021

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@andyherrick andyherrick marked this pull request as ready for review Sep 10, 2021
@openjdk openjdk bot added the rfr label Sep 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 10, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. You will need to fix a typo in the title of this PR.

@andyherrick andyherrick changed the title JDK-8273593: [REDO] Warn user when using mac-sign option with usiigned app-image. JDK-8273593: [REDO] Warn user when using mac-sign option with usigned app-image. Sep 10, 2021
@andyherrick andyherrick changed the title JDK-8273593: [REDO] Warn user when using mac-sign option with usigned app-image. JDK-8273593: [REDO] Warn user when using mac-sign option with unsigned app-image. Sep 10, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 11, 2021

@alexeysemenyukoracle please review

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273593: [REDO] Warn user when using mac-sign option with unsigned app-image.

Reviewed-by: kcr, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 4dff991: 8269687: pauth_aarch64.hpp include name is incorrect
  • 0e847cf: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling
  • d9a7fc6: Merge
  • 4afbcaf: 8273592: Backout JDK-8271868
  • a37254c: 8271868: Warn user when using mac-sign option with unsigned app-image.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 14, 2021
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Sep 14, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

Going to push as commit ec0b85a.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 4dff991: 8269687: pauth_aarch64.hpp include name is incorrect
  • 0e847cf: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling
  • d9a7fc6: Merge
  • 4afbcaf: 8273592: Backout JDK-8271868
  • a37254c: 8271868: Warn user when using mac-sign option with unsigned app-image.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@andyherrick Pushed as commit ec0b85a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andyherrick andyherrick deleted the JDK-8273593 branch Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants