Skip to content

8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT #73

wants to merge 1 commit into from

Conversation

jovanstevanovic
Copy link
Contributor

@jovanstevanovic jovanstevanovic commented Sep 13, 2021

This PR is backporting changes from PR on the OpenJDK repo.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/73/head:pull/73
$ git checkout pull/73

Update a local copy of the PR:
$ git checkout pull/73
$ git pull https://git.openjdk.java.net/jdk17u pull/73/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 73

View PR using the GUI difftool:
$ git pr show -t 73

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/73.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2021

👋 Welcome back jovanstevanovic! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2021

Webrevs

@RealCLanger
Copy link
Contributor

Same here, please change PR title to "Backport f690a01f1e5de4ace39aefad656cb7c99f9ec4e1" to have the bots recognize the backport correctly.

@jovanstevanovic jovanstevanovic changed the title 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT Backport f690a01f1e5de4ace39aefad656cb7c99f9ec4e1 Sep 13, 2021
@openjdk openjdk bot changed the title Backport f690a01f1e5de4ace39aefad656cb7c99f9ec4e1 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT Sep 13, 2021
@openjdk
Copy link

openjdk bot commented Sep 13, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 13, 2021

⚠️ @jovanstevanovic the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout jovanstevanovic/improving-xslt-support-for-native-image
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Sep 13, 2021

@jovanstevanovic This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • cdd4075: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7
  • 2586eb0: 8274087: Windows DLL path not set correctly.
  • d6d5a9a: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • a702838: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS
  • 84f6cb4: 8273498: compiler/c2/Test7179138_1.java timed out
  • c4b3d62: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
  • f4a0b13: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
  • fd81865: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • 962f393: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • 7298db5: 8223923: C2: Missing interference with mismatched unsafe accesses
  • ... and 40 more: https://git.openjdk.java.net/jdk17u/compare/0e847cfb151d1485483b7edd938c9113d703cd4b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 13, 2021
@jovanstevanovic
Copy link
Contributor Author

Same here, please change PR title to "Backport f690a01f1e5de4ace39aefad656cb7c99f9ec4e1" to have the bots recognize the backport correctly.

Done.

@RealCLanger
Copy link
Contributor

OK, great. So for this one, you'll only need to add the jdk17u-fix-request label to the JBS bug and write a comment why you want to backport, what's the risk and what testing you did. Then wait for approval. After you have approval, you can integrate it. No need for PR review necessary since the backport applied clean.

@jovanstevanovic
Copy link
Contributor Author

jovanstevanovic commented Sep 13, 2021

OK, great. So for this one, you'll only need to add the jdk17u-fix-request label to the JBS bug and write a comment why you want to backport, what's the risk and what testing you did. Then wait for approval. After you have approval, you can integrate it. No need for PR review necessary since the backport applied clean.

Done. JBS issue is updated.

@RealCLanger
Copy link
Contributor

@jovanstevanovic This one was approved. You can integrate it...

@jovanstevanovic
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@jovanstevanovic
Your change (at version 786da23) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

Going to push as commit 20afdfd.
Since your change was applied there have been 50 commits pushed to the master branch:

  • cdd4075: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7
  • 2586eb0: 8274087: Windows DLL path not set correctly.
  • d6d5a9a: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • a702838: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS
  • 84f6cb4: 8273498: compiler/c2/Test7179138_1.java timed out
  • c4b3d62: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
  • f4a0b13: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
  • fd81865: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • 962f393: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • 7298db5: 8223923: C2: Missing interference with mismatched unsafe accesses
  • ... and 40 more: https://git.openjdk.java.net/jdk17u/compare/0e847cfb151d1485483b7edd938c9113d703cd4b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@RealCLanger @jovanstevanovic Pushed as commit 20afdfd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jovanstevanovic jovanstevanovic deleted the jovanstevanovic/improving-xslt-support-for-native-image branch September 30, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants