Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers #75

Closed
wants to merge 1 commit into from
Closed

8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers #75

wants to merge 1 commit into from

Conversation

@reinrich
Copy link
Contributor

@reinrich reinrich commented Sep 14, 2021

Hi all,

this pull request contains a clean backport of commit 4abe5311 from the openjdk/jdk repository.
I would like to backport this to 17u to avoid false positives in 17u tests.
The commit being backported was authored by Richard Reingruber on 5 Aug 2021 and was reviewed by Albert Mingkun Yang and Thomas Schatzl.

Thanks!
Richard.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/75/head:pull/75
$ git checkout pull/75

Update a local copy of the PR:
$ git checkout pull/75
$ git pull https://git.openjdk.java.net/jdk17u pull/75/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 75

View PR using the GUI difftool:
$ git pr show -t 75

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/75.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2021

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 4abe5311407c68d04fb0babb87fa279e35d5fabc 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers Sep 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2021

Webrevs

Loading

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Sep 14, 2021

/cc hotspot-gc

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@reinrich The label hotspot-gc is not a valid label. These labels are valid:

Loading

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Sep 15, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

Going to push as commit 20be766.
Since your change was applied there have been 52 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@reinrich Pushed as commit 20be766.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant