Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8272639: jpackaged applications using microphone on mac #76

Closed
wants to merge 1 commit into from

Conversation

andyherrick
Copy link

@andyherrick andyherrick commented Sep 14, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272639: jpackaged applications using microphone on mac ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/76/head:pull/76
$ git checkout pull/76

Update a local copy of the PR:
$ git checkout pull/76
$ git pull https://git.openjdk.java.net/jdk17u pull/76/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 76

View PR using the GUI difftool:
$ git pr show -t 76

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/76.diff

@andyherrick
Copy link
Author

andyherrick commented Sep 14, 2021

Direct backport of: JDK-8272639 jpackaged applications using microphone on mac

@andyherrick andyherrick marked this pull request as ready for review September 14, 2021 20:34
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2021

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 14, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2021

Webrevs

@andyherrick andyherrick changed the title JDK-8273241: jpackaged applications using microphone on mac JDK-8271868: jpackaged applications using microphone on mac Sep 16, 2021
@andyherrick andyherrick changed the title JDK-8271868: jpackaged applications using microphone on mac JDK-8272639: jpackaged applications using microphone on mac Sep 16, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272639: jpackaged applications using microphone on mac

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 20be766: 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers
  • f8ecff4: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 808356a: 8273358: macOS Monterey does not have the font Times needed by Serif

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 17, 2021
@andyherrick
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 17, 2021

Going to push as commit da1c0fe.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 20be766: 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers
  • f8ecff4: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 808356a: 8273358: macOS Monterey does not have the font Times needed by Serif

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@andyherrick Pushed as commit da1c0fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andyherrick andyherrick deleted the JDK-8273241 branch September 29, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants