Skip to content

Conversation

@jmtd
Copy link

@jmtd jmtd commented Sep 16, 2021

Patch applies cleanly and fixes a test which otherwise always passes. Confirmed on Linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/78/head:pull/78
$ git checkout pull/78

Update a local copy of the PR:
$ git checkout pull/78
$ git pull https://git.openjdk.java.net/jdk17u pull/78/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 78

View PR using the GUI difftool:
$ git pr show -t 78

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/78.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2021

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a5ad7720d235610ad45fc341c61f164805f82a54 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions Sep 16, 2021
@openjdk
Copy link

openjdk bot commented Sep 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 16, 2021
@openjdk
Copy link

openjdk bot commented Sep 16, 2021

@jmtd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2021

Webrevs

@jmtd
Copy link
Author

jmtd commented Sep 16, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 16, 2021
@openjdk
Copy link

openjdk bot commented Sep 16, 2021

@jmtd
Your change (at version f89f585) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/integrate

Same here, please don't integrate before maintainer approval.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

Going to push as commit 912ae51.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 74de3ef: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure
  • 793d08a: 8214761: Bug in parallel Kahan summation implementation
  • cd1d3e0: 8272318: Improve performance of HeapDumpAllTest
  • 3a650aa: 8271605: Update JMH devkit to 1.32
  • bf788ee: 8271862: C2 intrinsic for Reference.refersTo() is often not used
  • 92ff652: 8272970: Parallelize runtime/InvocationTests/
  • c2dc88f: 8272850: Drop zapping values in the Zap* option descriptions
  • fc8078a: 8263375: Support stack watermarks in Zero VM
  • 759cbcb: 8272838: Move CriticalJNI tests out of tier1
  • da1c0fe: 8272639: jpackaged applications using microphone on mac

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@RealCLanger @jmtd Pushed as commit 912ae51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants