Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273902: Memory leak in OopStorage due to bug in OopHandle::release() #79

Closed
wants to merge 1 commit into from
Closed

8273902: Memory leak in OopStorage due to bug in OopHandle::release() #79

wants to merge 1 commit into from

Conversation

@simonis
Copy link
Member

@simonis simonis commented Sep 16, 2021

Hi all,

this pull request contains a backport of commit bc48a0ac from the openjdk/jdk repository.

The commit being backported was authored by Volker Simonis on 16 Sep 2021 and was reviewed by Serguei Spitsyn and Coleen Phillimore.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273902: Memory leak in OopStorage due to bug in OopHandle::release()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/79/head:pull/79
$ git checkout pull/79

Update a local copy of the PR:
$ git checkout pull/79
$ git pull https://git.openjdk.java.net/jdk17u pull/79/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 79

View PR using the GUI difftool:
$ git pr show -t 79

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/79.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 16, 2021

👋 Welcome back simonis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport bc48a0ac297b99a997482dcb59f85acc1cdb0c47 8273902: Memory leak in OopStorage due to bug in OopHandle::release() Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@simonis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273902: Memory leak in OopStorage due to bug in OopHandle::release()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 16, 2021

Webrevs

Loading

@simonis
Copy link
Member Author

@simonis simonis commented Sep 27, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

Going to push as commit 926a815.
Since your change was applied there have been 18 commits pushed to the master branch:

  • d46a5ae: 8274056: JavaAccessibilityUtilities leaks JNI objects
  • 7b67581: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • 00f7c45: 8273451: Remove unreachable return in mutexLocker::wait
  • 227e159: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop
  • 9d590fc: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • 8cd9319: 8274215: Remove globalsignr2ca root from 17.0.2
  • cb6a08c: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher
  • 912ae51: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions
  • 74de3ef: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure
  • 793d08a: 8214761: Bug in parallel Kahan summation implementation
  • ... and 8 more: https://git.openjdk.java.net/jdk17u/compare/20be766ed90849703e32dfc4481505612400e0e6...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

@simonis Pushed as commit 926a815.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant