Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267625: AARCH64: typo in LIR_Assembler::emit_profile_type #8

Closed
wants to merge 1 commit into from
Closed

8267625: AARCH64: typo in LIR_Assembler::emit_profile_type #8

wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 2, 2021

Hi all,

this pull request contains a backport of JDK-8267625 from the openjdk/jdk repository.

The commit being backported was authored by Nick Gasson on 7 Jul 2021 and was reviewed by Andrew Haley and Dean Long.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8267625: AARCH64: typo in LIR_Assembler::emit_profile_type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.java.net/jdk17u pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/8.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 2, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3d090e7ee561252027c06021b337c69a39f724e1 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type Aug 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267625: AARCH64: typo in LIR_Assembler::emit_profile_type

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

  • a575f5c: 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events
  • de808a5: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • afede39: Merge
  • f8fb571: 8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34)
  • e351de3: 8271272: C2: assert(!had_error) failed: bad dominance
  • 6180cf1: 8271512: ProblemList serviceability/sa/sadebugd/DebugdConnectTest.java due to 8270326
  • a1b5b81: 8271507: ProblemList SA tests that are failing with ZGC due to JDK-8248912
  • 286d313: 8271489: (doc) Clarify Filter Factory example
  • 20d2dc1: 8271403: mark hotspot runtime/memory tests which ignore external VM flags
  • e593e3d: 8271402: mark hotspot runtime/os tests which ignore external VM flags
  • ... and 51 more: https://git.openjdk.java.net/jdk17u/compare/9b6aa5304c4768b1200cd1f0990fee4d0e9a2600...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Aug 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 2, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Aug 4, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

Going to push as commit 9175a8d.
Since your change was applied there have been 61 commits pushed to the master branch:

  • a575f5c: 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events
  • de808a5: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • afede39: Merge
  • f8fb571: 8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34)
  • e351de3: 8271272: C2: assert(!had_error) failed: bad dominance
  • 6180cf1: 8271512: ProblemList serviceability/sa/sadebugd/DebugdConnectTest.java due to 8270326
  • a1b5b81: 8271507: ProblemList SA tests that are failing with ZGC due to JDK-8248912
  • 286d313: 8271489: (doc) Clarify Filter Factory example
  • 20d2dc1: 8271403: mark hotspot runtime/memory tests which ignore external VM flags
  • e593e3d: 8271402: mark hotspot runtime/os tests which ignore external VM flags
  • ... and 51 more: https://git.openjdk.java.net/jdk17u/compare/9b6aa5304c4768b1200cd1f0990fee4d0e9a2600...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@RealCLanger Pushed as commit 9175a8d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants