Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds #80

Closed
wants to merge 1 commit into from
Closed

8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds #80

wants to merge 1 commit into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Sep 20, 2021

Hi all,

I would like to backport this trivial change (applies cleanly) to 17. Shaves ~20 seconds from metaspace gtests. Thank you.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/80/head:pull/80
$ git checkout pull/80

Update a local copy of the PR:
$ git checkout pull/80
$ git pull https://git.openjdk.java.net/jdk17u pull/80/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 80

View PR using the GUI difftool:
$ git pr show -t 80

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/80.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bb9d142759ece7665329b124a8ea0b16049b024a 8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2021

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Sep 21, 2021

Note: MacOS build errors in GHA unrelated.

@tstuefe
Copy link
Member Author

tstuefe commented Oct 7, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2021

Going to push as commit 9352fa2.
Since your change was applied there have been 75 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2021
@openjdk
Copy link

openjdk bot commented Oct 7, 2021

@tstuefe Pushed as commit 9352fa2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant