Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8214761: Bug in parallel Kahan summation implementation #81

Closed
wants to merge 1 commit into from
Closed

8214761: Bug in parallel Kahan summation implementation #81

wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Sep 20, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8214761: Bug in parallel Kahan summation implementation

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/81/head:pull/81
$ git checkout pull/81

Update a local copy of the PR:
$ git checkout pull/81
$ git pull https://git.openjdk.java.net/jdk17u pull/81/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 81

View PR using the GUI difftool:
$ git pr show -t 81

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/81.diff

@jddarcy
Copy link
Member Author

jddarcy commented Sep 20, 2021

/integrate

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot changed the title Backport dd871819a05886ee09fc00c7c778268440ebedb7 8214761: Bug in parallel Kahan summation implementation Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8214761: Bug in parallel Kahan summation implementation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c2dc88f: 8272850: Drop zapping values in the Zap* option descriptions
  • fc8078a: 8263375: Support stack watermarks in Zero VM
  • 759cbcb: 8272838: Move CriticalJNI tests out of tier1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2021
@jddarcy
Copy link
Member Author

jddarcy commented Sep 20, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

Going to push as commit 793d08a.
Since your change was applied there have been 7 commits pushed to the master branch:

  • cd1d3e0: 8272318: Improve performance of HeapDumpAllTest
  • 3a650aa: 8271605: Update JMH devkit to 1.32
  • bf788ee: 8271862: C2 intrinsic for Reference.refersTo() is often not used
  • 92ff652: 8272970: Parallelize runtime/InvocationTests/
  • c2dc88f: 8272850: Drop zapping values in the Zap* option descriptions
  • fc8078a: 8263375: Support stack watermarks in Zero VM
  • 759cbcb: 8272838: Move CriticalJNI tests out of tier1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@jddarcy Pushed as commit 793d08a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Sep 20, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@jddarcy The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant