Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher #84

Closed
wants to merge 1 commit into from

Conversation

@thejasviv
Copy link
Member

@thejasviv thejasviv commented Sep 23, 2021

This is a straight, clean backport of the following change:

8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher

The patch applies cleanly, and the tests pass following the patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/84/head:pull/84
$ git checkout pull/84

Update a local copy of the PR:
$ git checkout pull/84
$ git pull https://git.openjdk.java.net/jdk17u pull/84/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 84

View PR using the GUI difftool:
$ git pr show -t 84

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/84.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 23, 2021

👋 Welcome back tvoniadka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport a5108a605e6a1e427d90dbeeb8630a3d01d6b405 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@thejasviv This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@thejasviv
Copy link
Member Author

@thejasviv thejasviv commented Sep 23, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@thejasviv
Your change (at version df90bbc) is now ready to be sponsored by a Committer.

Loading

@akolarkunnu
Copy link
Contributor

@akolarkunnu akolarkunnu commented Sep 23, 2021

/sponsor

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 23, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

Going to push as commit cb6a08c.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@akolarkunnu @thejasviv Pushed as commit cb6a08c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants