-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274215: Remove globalsignr2ca root from 17.0.2 #86
Conversation
👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into |
@@ -27,7 +27,7 @@ | |||
* @bug 8189131 8198240 8191844 8189949 8191031 8196141 8204923 8195774 8199779 | |||
* 8209452 8209506 8210432 8195793 8216577 8222089 8222133 8222137 8222136 | |||
* 8223499 8225392 8232019 8234245 8233223 8225068 8225069 8243321 8243320 | |||
* 8243559 8225072 8258630 8259312 8256421 8225081 8225082 | |||
* 8243559 8225072 8258630 8259312 8256421 8225081 8225082 8225083 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept old bug id in the test to simplify backports in future.
@rhalade This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 8cd9319. |
"globalsignr2ca [jdk]" was removed with JDK-8225083. This fix got pulled in to 17.0.1 (Oct 2021) release so had to be backed out with JDK-8273150. Since it was not allowed to be backed out from 17.0.1 repo only, it was backed out from 17.0.2 as well.
Now that Oct release is finalized, the fix for JDK-8225083 can be added back to 17.0.2.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/86/head:pull/86
$ git checkout pull/86
Update a local copy of the PR:
$ git checkout pull/86
$ git pull https://git.openjdk.java.net/jdk17u pull/86/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 86
View PR using the GUI difftool:
$ git pr show -t 86
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/86.diff