Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274215: Remove globalsignr2ca root from 17.0.2 #86

Closed
wants to merge 1 commit into from

Conversation

@rhalade
Copy link
Member

@rhalade rhalade commented Sep 23, 2021

"globalsignr2ca [jdk]" was removed with JDK-8225083. This fix got pulled in to 17.0.1 (Oct 2021) release so had to be backed out with JDK-8273150. Since it was not allowed to be backed out from 17.0.1 repo only, it was backed out from 17.0.2 as well.

Now that Oct release is finalized, the fix for JDK-8225083 can be added back to 17.0.2.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/86/head:pull/86
$ git checkout pull/86

Update a local copy of the PR:
$ git checkout pull/86
$ git pull https://git.openjdk.java.net/jdk17u pull/86/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 86

View PR using the GUI difftool:
$ git pr show -t 86

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/86.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 23, 2021

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@@ -27,7 +27,7 @@
* @bug 8189131 8198240 8191844 8189949 8191031 8196141 8204923 8195774 8199779
* 8209452 8209506 8210432 8195793 8216577 8222089 8222133 8222137 8222136
* 8223499 8225392 8232019 8234245 8233223 8225068 8225069 8243321 8243320
* 8243559 8225072 8258630 8259312 8256421 8225081 8225082
* 8243559 8225072 8258630 8259312 8256421 8225081 8225082 8225083
Copy link
Member Author

@rhalade rhalade Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept old bug id in the test to simplify backports in future.

Loading

@openjdk openjdk bot added the rfr label Sep 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 23, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274215: Remove globalsignr2ca root from 17.0.2

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 23, 2021
@rhalade
Copy link
Member Author

@rhalade rhalade commented Sep 23, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

Going to push as commit 8cd9319.

Loading

@openjdk openjdk bot closed this Sep 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@rhalade Pushed as commit 8cd9319.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@rhalade rhalade deleted the 8274215 branch Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants