Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F #89

Closed
wants to merge 1 commit into from
Closed

8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F #89

wants to merge 1 commit into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Sep 26, 2021

Hi all,

This is a fix for the testbug.

this pull request contains a backport of commit 6cf70f5f from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 15 Sep 2021 and was reviewed by Pankaj Bansal, Prasanta Sadhukhan and Alexander Zvegintsev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/89/head:pull/89
$ git checkout pull/89

Update a local copy of the PR:
$ git checkout pull/89
$ git pull https://git.openjdk.java.net/jdk17u pull/89/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 89

View PR using the GUI difftool:
$ git pr show -t 89

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/89.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 26, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 6cf70f5f0809276904094bf8eba8786892bf034e 8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F Sep 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 26, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 26, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 26, 2021
@mrserb mrserb marked this pull request as ready for review Sep 26, 2021
@openjdk openjdk bot added the rfr label Sep 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 26, 2021

Webrevs

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 28, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

Going to push as commit c4dfa57.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 926a815: 8273902: Memory leak in OopStorage due to bug in OopHandle::release()
  • d46a5ae: 8274056: JavaAccessibilityUtilities leaks JNI objects
  • 7b67581: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • 00f7c45: 8273451: Remove unreachable return in mutexLocker::wait
  • 227e159: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@mrserb Pushed as commit c4dfa57.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant