Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273451: Remove unreachable return in mutexLocker::wait #90

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Sep 27, 2021

I'd like to backport JDK-8273451 to jdk17u.
The original patch applied cleanly.
It's a code cleanup, the patch removes the unreachable statement.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273451: Remove unreachable return in mutexLocker::wait

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/90/head:pull/90
$ git checkout pull/90

Update a local copy of the PR:
$ git checkout pull/90
$ git pull https://git.openjdk.java.net/jdk17u pull/90/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 90

View PR using the GUI difftool:
$ git pr show -t 90

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/90.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 27, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9b5991e811b789fe8b60701657c2f0dd2c222c2e 8273451: Remove unreachable return in mutexLocker::wait Sep 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Sep 27, 2021
@omikhaltsova
Copy link
Author

@omikhaltsova omikhaltsova commented Sep 27, 2021

/integrate

@openjdk openjdk bot added the clean label Sep 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273451: Remove unreachable return in  mutexLocker::wait

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9d590fc: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Sep 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

@omikhaltsova
Your change (at version dbb3847) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Sep 27, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 27, 2021

Webrevs

@yan-too
Copy link

@yan-too yan-too commented Sep 27, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

Going to push as commit 00f7c45.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 227e159: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop
  • 9d590fc: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Sep 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

@yan-too @omikhaltsova Pushed as commit 00f7c45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants