Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271718: Crash when during color transformation the color profile is replaced #91

Closed
wants to merge 1 commit into from
Closed

8271718: Crash when during color transformation the color profile is replaced #91

wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 28, 2021

Hi all,

This is the fix for jvm crash, see openjdk/jdk#5042 for additional detail

this pull request contains a backport of commit 14893527 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 10 Aug 2021 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271718: Crash when during color transformation the color profile is replaced

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/91/head:pull/91
$ git checkout pull/91

Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.java.net/jdk17u pull/91/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 91

View PR using the GUI difftool:
$ git pr show -t 91

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/91.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 148935279d177e66a08a7003975bce3077104e07 8271718: Crash when during color transformation the color profile is replaced Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271718: Crash when during color transformation the color profile is replaced

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2021
@mrserb mrserb marked this pull request as ready for review Sep 28, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 28, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2021

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Sep 28, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

Going to push as commit b55ec5b.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 4e707bc: 8268894: forged ASTs can provoke an AIOOBE at com.sun.tools.javac.jvm.ClassWriter::writePosition
  • d935001: 8268893: jcmd to trim the glibc heap

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@mrserb Pushed as commit b55ec5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant