Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character #92

Closed
wants to merge 1 commit into from

Conversation

thejasviv
Copy link
Member

@thejasviv thejasviv commented Sep 28, 2021

This is a straight, clean backport of the following change:

8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character

The patch applied clean, and the test passed on all platforms. Please approve this review. I will request integration once the 17-ok is received.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/92/head:pull/92
$ git checkout pull/92

Update a local copy of the PR:
$ git checkout pull/92
$ git pull https://git.openjdk.java.net/jdk17u pull/92/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 92

View PR using the GUI difftool:
$ git pr show -t 92

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/92.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2021

👋 Welcome back tvoniadka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7f78803b0926ea194334ad9b3c9f06cbe17a83dd 8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@thejasviv This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • f48db89: 8272328: java.library.path is not set properly by Windows jpackage app launcher
  • b55ec5b: 8271718: Crash when during color transformation the color profile is replaced
  • 4e707bc: 8268894: forged ASTs can provoke an AIOOBE at com.sun.tools.javac.jvm.ClassWriter::writePosition
  • d935001: 8268893: jcmd to trim the glibc heap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2021

Webrevs

@thejasviv
Copy link
Member Author

thejasviv commented Sep 29, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@thejasviv
Your change (at version 139a929) is now ready to be sponsored by a Committer.

@akolarkunnu
Copy link
Contributor

akolarkunnu commented Sep 29, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 29, 2021

Going to push as commit c2d1db9.
Since your change was applied there have been 4 commits pushed to the master branch:

  • f48db89: 8272328: java.library.path is not set properly by Windows jpackage app launcher
  • b55ec5b: 8271718: Crash when during color transformation the color profile is replaced
  • 4e707bc: 8268894: forged ASTs can provoke an AIOOBE at com.sun.tools.javac.jvm.ClassWriter::writePosition
  • d935001: 8268893: jcmd to trim the glibc heap

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@akolarkunnu @thejasviv Pushed as commit c2d1db9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants