Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273165: GraphKit::combine_exception_states fails with "matching stack sizes" assert #95

Closed
wants to merge 1 commit into from
Closed

8273165: GraphKit::combine_exception_states fails with "matching stack sizes" assert #95

wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 28, 2021

Backport of JDK-8273165. Applies cleanly. Approval is pending.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273165: GraphKit::combine_exception_states fails with "matching stack sizes" assert

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/95/head:pull/95
$ git checkout pull/95

Update a local copy of the PR:
$ git checkout pull/95
$ git pull https://git.openjdk.java.net/jdk17u pull/95/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 95

View PR using the GUI difftool:
$ git pr show -t 95

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/95.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 632a7e0885596b70d34be319bd09d4df8e151d12 8273165: GraphKit::combine_exception_states fails with "matching stack sizes" assert Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273165: GraphKit::combine_exception_states fails with "matching stack sizes" assert

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2021

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Sep 29, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

Going to push as commit 056eca0.
Since your change was applied there have been 8 commits pushed to the master branch:

  • ff3e90f: 8272570: C2: crash in PhaseCFG::global_code_motion
  • 108e1bd: 8271254: javac generates unreachable code when using empty semicolon statement
  • dd70512: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
  • c2d1db9: 8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character
  • f48db89: 8272328: java.library.path is not set properly by Windows jpackage app launcher
  • b55ec5b: 8271718: Crash when during color transformation the color profile is replaced
  • 4e707bc: 8268894: forged ASTs can provoke an AIOOBE at com.sun.tools.javac.jvm.ClassWriter::writePosition
  • d935001: 8268893: jcmd to trim the glibc heap

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@TobiHartmann Pushed as commit 056eca0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant