8278628: jdk/jfr/jmx/streaming/TestMaxSize.java Expected only one or two chunks

[egahlin]

Hi,

Could I have review of a test fix.

The test expects at most two chunks in the file repository. While it is true that RemoteRecordingStream::setMaxSize(1_000_000) will make sure there are not more than two known chunks, there can potentially be three files, which is what the test looks for. A file has to be completed before it becomes known to setMaxSize.

Testing: jdk/jfr/jmx/streaming/TestMaxSize

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8278628: jdk/jfr/jmx/streaming/TestMaxSize.java Expected only one or two chunks

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/105/head:pull/105
$ git checkout pull/105

Update a local copy of the PR:
$ git checkout pull/105
$ git pull https://git.openjdk.java.net/jdk18 pull/105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 105

View PR using the GUI difftool:
$ git pr show -t 105

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/105.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3fe51be3)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278628: jdk/jfr/jmx/streaming/TestMaxSize.java Expected only one or two chunks

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• e38df21: 8256291: RunThese30M fails "assert(_class_unload ? true : ((((JfrTraceIdBits::load(class_loader_klass)) & ((1 << 4) << 8)) != 0))) failed: invariant"
• 4d9b3f4: 8279998: PPC64 debug builds fail with "untested: RangeCheckStub: predicate_failed_trap_id"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit bd35f97.
Since your change was applied there have been 2 commits pushed to the master branch:

• e38df21: 8256291: RunThese30M fails "assert(_class_unload ? true : ((((JfrTraceIdBits::load(class_loader_klass)) & ((1 << 4) << 8)) != 0))) failed: invariant"
• 4d9b3f4: 8279998: PPC64 debug builds fail with "untested: RangeCheckStub: predicate_failed_trap_id"

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit bd35f97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.