Skip to content
This repository has been archived by the owner. It is now read-only.

8280155: [PPC64, s390] frame size checks are not yet correct #107

Closed
wants to merge 2 commits into from
Closed

8280155: [PPC64, s390] frame size checks are not yet correct #107

wants to merge 2 commits into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jan 18, 2022

Fix frame size check and do null check earlier as described in the JBS issue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280155: [PPC64, s390] frame size checks are not yet correct

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/107/head:pull/107
$ git checkout pull/107

Update a local copy of the PR:
$ git checkout pull/107
$ git pull https://git.openjdk.java.net/jdk18 pull/107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 107

View PR using the GUI difftool:
$ git pr show -t 107

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/107.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 18, 2022

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Jan 18, 2022
Copy link
Member

@MBaesken MBaesken left a comment

Hi Martin, this looks good to me; but please fix the copyright years in src/hotspot/os_cpu/linux_ppc/thread_linux_ppc.cpp .

@TheRealMDoerr TheRealMDoerr changed the title [PPC64, s390] frame size checks are not yet correct 8280155: [PPC64, s390] frame size checks are not yet correct Jan 18, 2022
@openjdk
Copy link

openjdk bot commented Jan 18, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280155: [PPC64, s390] frame size checks are not yet correct

Reviewed-by: mbaesken, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 18, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2022

Webrevs

Copy link

@RealLucy RealLucy left a comment

Changes look good to me!

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Jan 19, 2022

Thanks for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Jan 19, 2022

Going to push as commit f37bfea.
Since your change was applied there have been 33 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 19, 2022
@openjdk openjdk bot closed this Jan 19, 2022
@openjdk openjdk bot removed ready rfr labels Jan 19, 2022
@openjdk
Copy link

openjdk bot commented Jan 19, 2022

@TheRealMDoerr Pushed as commit f37bfea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8280155_frame_checks branch Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot integrated
3 participants