Skip to content
This repository has been archived by the owner. It is now read-only.

8280234: AArch64 "core" variant does not build after JDK-8270947 #108

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Jan 19, 2022

Trivial (?) fix for AArch64 build failure:

=== Output from failing command(s) repeated here ===
* For target hotspot_variant-core_libjvm_objs_macroAssembler_aarch64.o:
/home/shade/shipilev-jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp: In member function 'u_char* MacroAssembler::zero_words(Register, Register)':
/home/shade/shipilev-jdk/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp:4728:27: error: incomplete type 'ciEnv' used in nested name specifier
         && (task = ciEnv::current()->task())
                           ^~~~~~~ 

I'd like to get it to JDK 18, where it regressed, while we still at RDP1.

Additional testing:

  • Linux AArch64 fastdebug core build
  • Linux AArch64 fastdebug server build

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280234: AArch64 "core" variant does not build after JDK-8270947

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/108/head:pull/108
$ git checkout pull/108

Update a local copy of the PR:
$ git checkout pull/108
$ git pull https://git.openjdk.java.net/jdk18 pull/108/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 108

View PR using the GUI difftool:
$ git pr show -t 108

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/108.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 19, 2022
@openjdk
Copy link

openjdk bot commented Jan 19, 2022

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Jan 19, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2022

Webrevs

adinn
adinn approved these changes Jan 19, 2022
Copy link

@adinn adinn left a comment

Trivially good to go!

@openjdk
Copy link

openjdk bot commented Jan 19, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280234: AArch64 "core" variant does not build after JDK-8270947

Reviewed-by: adinn, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 19, 2022
Copy link

@theRealAph theRealAph left a comment

Hmm, I guess that's right. I do wonder whether Thread::is_Compiler_thread() is well-defined in a "core" build, but it does seem to be.

@shipilev
Copy link
Contributor Author

shipilev commented Jan 19, 2022

All right, AArch64 GHAs are clean, I am integrating under triviality rule.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 19, 2022

Going to push as commit 28e02fa.

@openjdk openjdk bot added the integrated label Jan 19, 2022
@openjdk openjdk bot closed this Jan 19, 2022
@openjdk openjdk bot removed ready rfr labels Jan 19, 2022
@openjdk
Copy link

openjdk bot commented Jan 19, 2022

@shipilev Pushed as commit 28e02fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot integrated
3 participants