8280233: Temporarily disable Unix domain sockets in Windows PipeImpl

[Michael-Mc-Mahon]

Hi,

Could I get the following change reviewed please? Pending full investigation of the cause of (JDK-8278369) we want to disable the use of Unix domain sockets in the Windows Pipe implementation, reverting to the previous (pre JDK 16) TCP socket impl. The TCP impl was always used in versions of windows other than 10, 2019 server+ that didn't support Unix domain sockets. There isn't a regression test as existing Pipe tests should be sufficient.

It's not clear at this point if the issue is a JDK or Windows bug but it's expected the Unix domain impl will be restored later. UNIX protocol family SocketChannel/ServerSocketChannels still work after this change.

Thanks,

Michael.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8280233: Temporarily disable Unix domain sockets in Windows PipeImpl

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/109/head:pull/109
$ git checkout pull/109

Update a local copy of the PR:
$ git checkout pull/109
$ git pull https://git.openjdk.java.net/jdk18 pull/109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 109

View PR using the GUI difftool:
$ git pr show -t 109

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/109.diff

[bridgekeeper]

👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Michael-Mc-Mahon The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (2085e82f)
• 01: Full - Incremental (19f3a5c4)
• 00: Full (5079d373)

[AlanBateman]

This looks okay. I assume you'll remove the import of java.net.StandardProtocolFamily and update the date in the copyright header too.

[openjdk]

@Michael-Mc-Mahon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280233: Temporarily disable Unix domain sockets in Windows PipeImpl

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 28e02fa: 8280234: AArch64 "core" variant does not build after JDK-8270947
• f37bfea: 8280155: [PPC64, s390] frame size checks are not yet correct

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[Michael-Mc-Mahon]

/integrate

[openjdk]

Going to push as commit 03680be.
Since your change was applied there have been 4 commits pushed to the master branch:

• be0538d: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling
• f5de6fa: 8272058: 25 Null pointer dereference defect groups in 4 files
• 28e02fa: 8280234: AArch64 "core" variant does not build after JDK-8270947
• f37bfea: 8280155: [PPC64, s390] frame size checks are not yet correct

Your commit was automatically rebased without conflicts.

[openjdk]

@Michael-Mc-Mahon Pushed as commit 03680be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.