Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8277072: ObjectStreamClass caches keep ClassLoaders alive #117

Closed

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Mar 9, 2022

Hi all,

This pull request contains a backport of commit 8eb453ba from the openjdk/jdk repository.

The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart.

It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277072: ObjectStreamClass caches keep ClassLoaders alive

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/117/head:pull/117
$ git checkout pull/117

Update a local copy of the PR:
$ git checkout pull/117
$ git pull https://git.openjdk.java.net/jdk18 pull/117/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 117

View PR using the GUI difftool:
$ git pr show -t 117

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/117.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 9, 2022

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 8277072: ObjectStreamClass caches keep ClassLoaders alive Mar 9, 2022
@openjdk
Copy link

openjdk bot commented Mar 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 9, 2022

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277072: ObjectStreamClass caches keep ClassLoaders alive

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 9, 2022
@openjdk
Copy link

openjdk bot commented Mar 9, 2022

@rkennke The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.java.net label Mar 9, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 9, 2022

Webrevs

@rkennke
Copy link
Contributor Author

rkennke commented Mar 9, 2022

Oops, I believe this should have been done vs jdk18u (not jdk18). Trying again.

@rkennke rkennke closed this Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.java.net ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants