-
Notifications
You must be signed in to change notification settings - Fork 65
8278607: Misc issues in foreign API javadoc #17
Conversation
|
👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into |
|
@mcimadamore The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
Mailing list message from John Rose on core-libs-dev: Nice work. I like this API a lot, and the doc is getting a good clear The run-on sentence at the top of `<h3>Foreign addresses</h3>` needs a On 13 Dec 2021, at 13:20, Maurizio Cimadamore wrote: |
|
|
||
| /** | ||
| * A memory address models a reference into a memory location. Memory addresses are typically obtained in three ways: | ||
| * A memory address models a reference into a memory location. Memory addresses are typically obtained in onw of the following ways: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should perhaps be one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@mcimadamore This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/integrate |
|
Going to push as commit d6b5544.
Your commit was automatically rebased without conflicts. |
|
@mcimadamore Pushed as commit d6b5544. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This patch fixes a number of issues and typos in the foreign API javadoc following another internal round of reviews.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/17/head:pull/17$ git checkout pull/17Update a local copy of the PR:
$ git checkout pull/17$ git pull https://git.openjdk.java.net/jdk18 pull/17/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17View PR using the GUI difftool:
$ git pr show -t 17Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/17.diff