Skip to content
This repository has been archived by the owner. It is now read-only.

8278233: [macos] tools/jpackage tests timeout due to /usr/bin/osascript #18

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Dec 14, 2021

This is regression from JDK-8276837. exec() was passing INFINITE_TIMEOUT instead of actual value of timeout variable. Execution of osascript was running without timeout and thus several tests timeout. Osascript hang during test execution is intermittent issue.

Also, removed IconTest.java and MultiNameTwoPhaseTest.java from ProblemList.txt.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278233: [macos] tools/jpackage tests timeout due to /usr/bin/osascript

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.java.net/jdk18 pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/18.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2021

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 14, 2021
@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@sashamatveev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.java.net label Dec 14, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278233: [macos] tools/jpackage tests timeout due to /usr/bin/osascript

Reviewed-by: herrick, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 0cc989b: 8278744: KeyStore:getAttributes() not returning unmodifiable Set
  • 475ec8e: 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording
  • 32139c1: 8262134: compiler/uncommontrap/TestDeoptOOM.java failed with "guarantee(false) failed: wrong number of expression stack elements during deopt"
  • c93b24d: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently
  • 9a1bbaf: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276
  • 9b99cbe: 8278580: ProblemList javax/swing/JTree/4908142/bug4908142.java on macosx-x64
  • 94127f4: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits
  • 0602f4c: 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
  • 3df8dc4: 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
  • ed5d53a: 8273179: Update nroff pages in JDK 18 before RC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2021
@sashamatveev
Copy link
Member Author

sashamatveev commented Dec 14, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2021

Going to push as commit 918e339.
Since your change was applied there have been 11 commits pushed to the master branch:

  • f48a3e8: 8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134
  • 0cc989b: 8278744: KeyStore:getAttributes() not returning unmodifiable Set
  • 475ec8e: 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording
  • 32139c1: 8262134: compiler/uncommontrap/TestDeoptOOM.java failed with "guarantee(false) failed: wrong number of expression stack elements during deopt"
  • c93b24d: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently
  • 9a1bbaf: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276
  • 9b99cbe: 8278580: ProblemList javax/swing/JTree/4908142/bug4908142.java on macosx-x64
  • 94127f4: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits
  • 0602f4c: 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
  • 3df8dc4: 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
  • ... and 1 more: https://git.openjdk.java.net/jdk18/compare/d40e90b4a1b55753a178d824c4c60209bc46efac...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2021
@openjdk openjdk bot closed this Dec 14, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2021
@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@sashamatveev Pushed as commit 918e339.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated
3 participants