-
Notifications
You must be signed in to change notification settings - Fork 66
8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134 #21
Conversation
…se VMs after JDK-8262134
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
@DamonFool The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/label hotspot-compiler |
@DamonFool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up. This is a trivial fix.
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks @dcubed-ojdk . |
Going to push as commit f48a3e8.
Your commit was automatically rebased without conflicts. |
@DamonFool Pushed as commit f48a3e8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs due to 'DeoptimizeALot' is develop after JDK-8262134.
This is because
-XX:+DeoptimizeALot
and-XX:+VerifyStack
are develop and are available only in debug version.The fix only run the test config added by JDK-8262134 with debug VMs.
Thanks.
Best regards,
Jie
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/21/head:pull/21
$ git checkout pull/21
Update a local copy of the PR:
$ git checkout pull/21
$ git pull https://git.openjdk.java.net/jdk18 pull/21/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21
View PR using the GUI difftool:
$ git pr show -t 21
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/21.diff