Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134 #21

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Dec 14, 2021

Hi all,

runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs due to 'DeoptimizeALot' is develop after JDK-8262134.
This is because -XX:+DeoptimizeALot and -XX:+VerifyStack are develop and are available only in debug version.

The fix only run the test config added by JDK-8262134 with debug VMs.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/21/head:pull/21
$ git checkout pull/21

Update a local copy of the PR:
$ git checkout pull/21
$ git pull https://git.openjdk.java.net/jdk18 pull/21/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21

View PR using the GUI difftool:
$ git pr show -t 21

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/21.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 14, 2021
@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.java.net label Dec 14, 2021
@DamonFool
Copy link
Member Author

/label hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.java.net label Dec 14, 2021
@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@DamonFool
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 14, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 475ec8e: 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2021
@DamonFool
Copy link
Member Author

Thumbs up. This is a trivial fix.

Thanks @dcubed-ojdk .
/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2021

Going to push as commit f48a3e8.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 0cc989b: 8278744: KeyStore:getAttributes() not returning unmodifiable Set
  • 475ec8e: 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2021
@openjdk openjdk bot closed this Dec 14, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2021
@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@DamonFool Pushed as commit f48a3e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.java.net hotspot-runtime hotspot-runtime-dev@openjdk.java.net integrated Pull request has been integrated
2 participants