Skip to content
This repository has been archived by the owner. It is now read-only.

8278604 SwingSet2 table demo does not have accessible description set for images #31

Closed
wants to merge 1 commit into from

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Dec 15, 2021

SwingSet2 demo is often used to check accessibility for different Swing components and has some shortcomings. The major one is that images within the table demo do not have accessible description set which makes accessibility perform differently on different platforms when navigating the table with screen narrator enabled.

This is the next step after the solution JDK-8277497, in which we forwarded the description from the icon into the label description so that this fix was possible.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8278604: SwingSet2 table demo does not have accessible description set for images
  • JDK-8278526: [macos] Screen reader reads SwingSet2 JTable row selection as null, dimmed row for last column

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/31/head:pull/31
$ git checkout pull/31

Update a local copy of the PR:
$ git checkout pull/31
$ git pull https://git.openjdk.java.net/jdk18 pull/31/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31

View PR using the GUI difftool:
$ git pr show -t 31

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/31.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 15, 2021

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

@savoptik The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Dec 15, 2021
@savoptik
Copy link
Contributor Author

@savoptik savoptik commented Dec 15, 2021

/reviewer credit @forantar @azuev-java @pankaj-bansal

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

@savoptik
Reviewer ant successfully credited.

Reviewer kizune successfully credited.

Reviewer pbansal successfully credited.

@savoptik
Copy link
Contributor Author

@savoptik savoptik commented Dec 15, 2021

/addissues 8278526

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

@savoptik Unknown command addissues - for a list of valid commands use /help.

@savoptik
Copy link
Contributor Author

@savoptik savoptik commented Dec 15, 2021

/help

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

@savoptik Available commands:

  • cc - add or remove an additional classification label
  • clean - Mark the backport pull request as a clean backport
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • label - add or remove an additional classification label
  • open - Set the pull request state to "open"
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests

@savoptik
Copy link
Contributor Author

@savoptik savoptik commented Dec 15, 2021

/issue add 8278526

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

@savoptik
Adding additional issue to issue list: 8278526: [macos] Screen reader reads SwingSet2 JTable row selection as null, dimmed row for last column.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 15, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278604: SwingSet2 table demo does not have accessible description set for images
8278526: [macos] Screen reader reads SwingSet2 JTable row selection as null, dimmed row for last column

Reviewed-by: ant, kizune, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • b46f0b0: 8277447: Hotspot C1 compiler crashes on Kotlin suspend fun with loop
  • 9cd7090: 8278587: StringTokenizer(String, String, boolean) documentation bug
  • fffa73c: 8269425: 2 jdk/jfr/api/consumer/streaming tests failed to attach
  • b9a477b: 8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert
  • bb7efb3: 8278790: Inner loop of long loop nest runs for too few iterations
  • 8494fec: 8278796: Incorrect behavior of FloatVector.withLane on X86
  • f5d7c77: 8276826: Clarify the ModuleDescriptor.Version specification’s treatment of repeated punctuation characters
  • be6b90d: 8278574: update --help-extra message to include default value of --finalization option
  • aec1b03: 8278389: SuspendibleThreadSet::_suspend_all should be volatile/atomic
  • e82310f: 8278575: update jcmd GC.finalizer_info to list finalization status
  • ... and 3 more: https://git.openjdk.java.net/jdk18/compare/918e3397858c425e9c3b82c9a918b7626603a59c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@forantar, @azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 15, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Dec 17, 2021

/reviewer credit @forantar @azuev-java @pankaj-bansal

@savoptik For future reference, the /reviewer credit command is not the way to request a review, but rather is a way to credit additional reviewers who have made significant review comments, but have not formally reviewed it in the GitHub PR.

@savoptik
Copy link
Contributor Author

@savoptik savoptik commented Dec 17, 2021

/integrate

@openjdk openjdk bot added the sponsor label Dec 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2021

@savoptik
Your change (at version 87c4584) is now ready to be sponsored by a Committer.

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Dec 17, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2021

Going to push as commit 8fbe172.
Since your change was applied there have been 13 commits pushed to the master branch:

  • b46f0b0: 8277447: Hotspot C1 compiler crashes on Kotlin suspend fun with loop
  • 9cd7090: 8278587: StringTokenizer(String, String, boolean) documentation bug
  • fffa73c: 8269425: 2 jdk/jfr/api/consumer/streaming tests failed to attach
  • b9a477b: 8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert
  • bb7efb3: 8278790: Inner loop of long loop nest runs for too few iterations
  • 8494fec: 8278796: Incorrect behavior of FloatVector.withLane on X86
  • f5d7c77: 8276826: Clarify the ModuleDescriptor.Version specification’s treatment of repeated punctuation characters
  • be6b90d: 8278574: update --help-extra message to include default value of --finalization option
  • aec1b03: 8278389: SuspendibleThreadSet::_suspend_all should be volatile/atomic
  • e82310f: 8278575: update jcmd GC.finalizer_info to list finalization status
  • ... and 3 more: https://git.openjdk.java.net/jdk18/compare/918e3397858c425e9c3b82c9a918b7626603a59c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 17, 2021
@openjdk openjdk bot closed this Dec 17, 2021
@openjdk openjdk bot removed ready rfr sponsor labels Dec 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2021

@azuev-java @savoptik Pushed as commit 8fbe172.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@forantar
Copy link

@forantar forantar commented Dec 20, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 20, 2021

@forantar The command sponsor can only be used in open pull requests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client integrated
4 participants