Skip to content
This repository has been archived by the owner. It is now read-only.

8278575: update jcmd GC.finalizer_info to list finalization status #33

Conversation

stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Dec 16, 2021

A simple patch that I inadvertently omitted from the original integration.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278575: update jcmd GC.finalizer_info to list finalization status

Reviewers

Contributors

  • David Holmes <dholmes@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/33/head:pull/33
$ git checkout pull/33

Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.java.net/jdk18 pull/33/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33

View PR using the GUI difftool:
$ git pr show -t 33

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/33.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 16, 2021

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2021

@stuart-marks The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Dec 16, 2021
@stuart-marks
Copy link
Member Author

@stuart-marks stuart-marks commented Dec 16, 2021

/issue JDK-8278575
/contributor add dholmes

@openjdk openjdk bot changed the title update jcmd GC.finalizer_info to list finalization status 8278575: update jcmd GC.finalizer_info to list finalization status Dec 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2021

@stuart-marks The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr label Dec 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2021

@stuart-marks
Contributor David Holmes <dholmes@openjdk.org> successfully added.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good to me. :)

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2021

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278575: update jcmd GC.finalizer_info to list finalization status

Co-authored-by: David Holmes <dholmes@openjdk.org>
Reviewed-by: dholmes, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • d3408a4: 8277964: ClassCastException with no stack trace is thrown with -Xcomp in method handle invocation
  • 69b5d49: 8272064: test/jdk/jdk/jfr/api/consumer/TestHiddenMethod.java needs update for JEP 416
  • d6b5544: 8278607: Misc issues in foreign API javadoc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 16, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@stuart-marks
Copy link
Member Author

@stuart-marks stuart-marks commented Dec 16, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2021

Going to push as commit e82310f.
Since your change was applied there have been 3 commits pushed to the master branch:

  • d3408a4: 8277964: ClassCastException with no stack trace is thrown with -Xcomp in method handle invocation
  • 69b5d49: 8272064: test/jdk/jdk/jfr/api/consumer/TestHiddenMethod.java needs update for JEP 416
  • d6b5544: 8278607: Misc issues in foreign API javadoc

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 16, 2021
@openjdk openjdk bot closed this Dec 16, 2021
@openjdk openjdk bot removed ready rfr labels Dec 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2021

@stuart-marks Pushed as commit e82310f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-runtime integrated
3 participants