8276826: Clarify the ModuleDescriptor.Version specification’s treatment of repeated punctuation characters

[mbreinhold]

Please review this tiny specification clarification.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed
• Change requires a CSR request to be approved

Issues

• JDK-8276826: Clarify the ModuleDescriptor.Version specification’s treatment of repeated punctuation characters
• JDK-8278465: Clarify the ModuleDescriptor.Version specification’s treatment of repeated punctuation characters (CSR)

Reviewers

• Mandy Chung (@mlchung - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/39/head:pull/39
$ git checkout pull/39

Update a local copy of the PR:
$ git checkout pull/39
$ git pull https://git.openjdk.java.net/jdk18 pull/39/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 39

View PR using the GUI difftool:
$ git pr show -t 39

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/39.diff

[mbreinhold]

/csr needed

[bridgekeeper]

👋 Welcome back mr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @mbreinhold a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master be6b90d90b54883ff17f9f5ac0f271de37df7e2a
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

[openjdk]

@mbreinhold has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@mbreinhold please create a CSR request for issue JDK-8278465. This pull request cannot be integrated until the CSR request is approved.

[mbreinhold]

Drat, used the wrong bug id.

[openjdk]

@mbreinhold The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9078f669)

[openjdk]

@mbreinhold This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276826: Clarify the ModuleDescriptor.Version specification’s treatment of repeated punctuation characters

Reviewed-by: mchung, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mbreinhold]

/integrate

[openjdk]

Going to push as commit f5d7c77.

[openjdk]

@mbreinhold Pushed as commit f5d7c77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.