Skip to content
This repository has been archived by the owner. It is now read-only.

8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 #4

Closed
wants to merge 1 commit into from

Conversation

asgibbons
Copy link
Contributor

@asgibbons asgibbons commented Dec 10, 2021

The base64 decoder overwrites memory past the end of its output buffer in certain cases. It will not overwrite if the encoded string length is < 64 bytes. It also will not overwrite if the encoded string length mod 64 is >= 16. So the case where it will overwrite is when the input string length (the encoded byte length) mod 64 is less than 16.

I also added a test case to detect this overrun.

/solves 8275427
/label hotspot
/label hotspot-compiler
/solves 8272809


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276
  • JDK-8272809: JFR thread sampler SI_KERNEL SEGV in metaspace::VirtualSpaceList::contains

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.java.net/jdk18 pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/4.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 10, 2021

👋 Welcome back asgibbons! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@asgibbons
Adding additional issue to solves list: 8275427: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java.util.ArrayList.add.

@openjdk openjdk bot added the hotspot label Dec 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@asgibbons
The hotspot label was successfully added.

@openjdk openjdk bot added the hotspot-compiler label Dec 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@asgibbons
The hotspot-compiler label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@asgibbons
Adding additional issue to solves list: 8272809: JFR thread sampler SI_KERNEL SEGV in metaspace::VirtualSpaceList::contains.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 10, 2021

Webrevs

Copy link

@sviswa7 sviswa7 left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@asgibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276
8272809: JFR thread sampler SI_KERNEL SEGV in metaspace::VirtualSpaceList::contains

Reviewed-by: sviswanathan, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 9b99cbe: 8278580: ProblemList javax/swing/JTree/4908142/bug4908142.java on macosx-x64
  • 94127f4: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits
  • 0602f4c: 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
  • 3df8dc4: 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
  • ed5d53a: 8273179: Update nroff pages in JDK 18 before RC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sviswa7, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 10, 2021
@asgibbons
Copy link
Contributor Author

@asgibbons asgibbons commented Dec 10, 2021

/integrate

@openjdk openjdk bot added the sponsor label Dec 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@asgibbons
Your change (at version e791fc0) is now ready to be sponsored by a Committer.

Copy link

@vnkozlov vnkozlov left a comment

Let me test it before approval.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Dec 10, 2021

@asgibbons I see that JDK-8275427 is closed as a duplicate. Normally, duplicates are not listed in the commit message of a fix.

@asgibbons
Copy link
Contributor Author

@asgibbons asgibbons commented Dec 10, 2021

@kevinrushforth Thanks for the tip. I believe it was marked as duplicate after I made this PR. I'll keep this in mind for future PRs.

/issue remove JDK-8275427

@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@asgibbons
Removing additional issue from issue list: 8275427.

@vnkozlov
Copy link

@vnkozlov vnkozlov commented Dec 10, 2021

You should closed other bugs as duplicate if you think the fix applied to them. Also you don't need to list them in PR because they are listed in JBS anyway.

Testing takes long time because, as test's name says, it runs for 24 hours. I want to make sure test passed with this fix.

Copy link

@vnkozlov vnkozlov left a comment

All testing passed.

@vnkozlov
Copy link

@vnkozlov vnkozlov commented Dec 12, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 12, 2021

Going to push as commit 9a1bbaf.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 9b99cbe: 8278580: ProblemList javax/swing/JTree/4908142/bug4908142.java on macosx-x64
  • 94127f4: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits
  • 0602f4c: 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
  • 3df8dc4: 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
  • ed5d53a: 8273179: Update nroff pages in JDK 18 before RC

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Dec 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 12, 2021

@vnkozlov @asgibbons Pushed as commit 9a1bbaf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot hotspot-compiler integrated
4 participants