8278970: [macos] SigningPackageTest is failed with runtime exception #42
Conversation
|
@sashamatveev The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@sashamatveev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
Going to push as commit 36676db.
Your commit was automatically rebased without conflicts. |
@sashamatveev Pushed as commit 36676db. |
This is regression from JDK-8263155. MacHelper.java is now calling test verification callback with all content in DMG root. SigningPackageTest expects only path with app name in it and thus it fails when trying to verify app inside ".background" folder. Fixed by checking that provided path for verification is actually an application we expecting. All other paths are ignored.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/42/head:pull/42
$ git checkout pull/42
Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.java.net/jdk18 pull/42/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 42
View PR using the GUI difftool:
$ git pr show -t 42
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/42.diff