Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8278970: [macos] SigningPackageTest is failed with runtime exception #42

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Dec 17, 2021

This is regression from JDK-8263155. MacHelper.java is now calling test verification callback with all content in DMG root. SigningPackageTest expects only path with app name in it and thus it fails when trying to verify app inside ".background" folder. Fixed by checking that provided path for verification is actually an application we expecting. All other paths are ignored.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278970: [macos] SigningPackageTest is failed with runtime exception

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/42/head:pull/42
$ git checkout pull/42

Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.java.net/jdk18 pull/42/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 42

View PR using the GUI difftool:
$ git pr show -t 42

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/42.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2021

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2021
@openjdk
Copy link

openjdk bot commented Dec 17, 2021

@sashamatveev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.java.net label Dec 17, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2021

Webrevs

@sashamatveev sashamatveev changed the title 8278907: JPackage test - SigningPackageTest is failed with runtime exception 8278970: [macos] SigningPackageTest is failed with runtime exception Dec 17, 2021
@openjdk
Copy link

openjdk bot commented Dec 17, 2021

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278970: [macos] SigningPackageTest is failed with runtime exception

Reviewed-by: herrick, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • a5f5d60: 8273107: RunThese24H times out with "java.lang.management.ThreadInfo.getLockName()" is null
  • 8fbe172: 8278604: SwingSet2 table demo does not have accessible description set for images
  • b46f0b0: 8277447: Hotspot C1 compiler crashes on Kotlin suspend fun with loop
  • 9cd7090: 8278587: StringTokenizer(String, String, boolean) documentation bug
  • fffa73c: 8269425: 2 jdk/jfr/api/consumer/streaming tests failed to attach
  • b9a477b: 8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert
  • bb7efb3: 8278790: Inner loop of long loop nest runs for too few iterations
  • 8494fec: 8278796: Incorrect behavior of FloatVector.withLane on X86

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 17, 2021
@sashamatveev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 17, 2021

Going to push as commit 36676db.
Since your change was applied there have been 8 commits pushed to the master branch:

  • a5f5d60: 8273107: RunThese24H times out with "java.lang.management.ThreadInfo.getLockName()" is null
  • 8fbe172: 8278604: SwingSet2 table demo does not have accessible description set for images
  • b46f0b0: 8277447: Hotspot C1 compiler crashes on Kotlin suspend fun with loop
  • 9cd7090: 8278587: StringTokenizer(String, String, boolean) documentation bug
  • fffa73c: 8269425: 2 jdk/jfr/api/consumer/streaming tests failed to attach
  • b9a477b: 8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert
  • bb7efb3: 8278790: Inner loop of long loop nest runs for too few iterations
  • 8494fec: 8278796: Incorrect behavior of FloatVector.withLane on X86

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 17, 2021
@openjdk openjdk bot closed this Dec 17, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 17, 2021
@openjdk
Copy link

openjdk bot commented Dec 17, 2021

@sashamatveev Pushed as commit 36676db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated
3 participants