JDK-8273179: Update nroff pages in JDK 18 before RC #5
JDK-8273179: Update nroff pages in JDK 18 before RC #5
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jon,
This all looks good - I'm familiar with many of the changes made to the sources but not yet generated.
We will have to be careful not to regress the copyright year or version if any subsequent updates are made before next year, or before the version loses the EA designator.
Thanks,
David
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Hi David, The copyright year will naturally sort itself out in a few weeks time ;-) When these changes make their way down from 18 to 19, we will probably want to regenerate these files with 19-EA. -- Jon |
We will also want to regenerate any appropriate files if any more updates to the man pages are made during the ramp down period. |
/integrate |
Going to push as commit ed5d53a. |
@jonathan-gibbons Pushed as commit ed5d53a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi @jonathan-gibbons , I have a couple of manpage related tasks for early in the 19 release cycle that will take care of updating the version number. Unfortunately for this change it looks like whomever did the source uodate to the javadoc manpage did not know about the test: test/langtools/jdk/javadoc/tool/CheckManPageOptions.java which is now failing on all platforms. :( I will file a bug. David |
hmmm, I thought we had taken care of that test. I will investigate |
Please review this semi-automatic update for the nroff man pages for JDK 18. The changes update the version number, copyright year, and incorporate the changes from the latest upstream files.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/5/head:pull/5
$ git checkout pull/5
Update a local copy of the PR:
$ git checkout pull/5
$ git pull https://git.openjdk.java.net/jdk18 pull/5/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5
View PR using the GUI difftool:
$ git pr show -t 5
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/5.diff