Skip to content
This repository has been archived by the owner. It is now read-only.

JDK-8273179: Update nroff pages in JDK 18 before RC #5

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Dec 10, 2021

Please review this semi-automatic update for the nroff man pages for JDK 18. The changes update the version number, copyright year, and incorporate the changes from the latest upstream files.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/5/head:pull/5
$ git checkout pull/5

Update a local copy of the PR:
$ git checkout pull/5
$ git pull https://git.openjdk.java.net/jdk18 pull/5/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5

View PR using the GUI difftool:
$ git pr show -t 5

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/5.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 10, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@jonathan-gibbons The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • hotspot-jfr
  • javadoc
  • kulla
  • net
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc serviceability core-libs net compiler kulla hotspot-jfr labels Dec 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 10, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Jon,

This all looks good - I'm familiar with many of the changes made to the sources but not yet generated.

We will have to be careful not to regress the copyright year or version if any subsequent updates are made before next year, or before the version loses the EA designator.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273179: Update nroff pages in JDK 18 before RC

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 10, 2021
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Dec 10, 2021

Hi David,

The copyright year will naturally sort itself out in a few weeks time ;-)

When these changes make their way down from 18 to 19, we will probably want to regenerate these files with 19-EA.

-- Jon

@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Dec 10, 2021

We will also want to regenerate any appropriate files if any more updates to the man pages are made during the ramp down period.

@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Dec 10, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

Going to push as commit ed5d53a.

@openjdk openjdk bot closed this Dec 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@jonathan-gibbons Pushed as commit ed5d53a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the 8273179-man-page-update branch Dec 10, 2021
@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Dec 10, 2021

Hi @jonathan-gibbons ,

I have a couple of manpage related tasks for early in the 19 release cycle that will take care of updating the version number.

Unfortunately for this change it looks like whomever did the source uodate to the javadoc manpage did not know about the test:

test/langtools/jdk/javadoc/tool/CheckManPageOptions.java

which is now failing on all platforms. :( I will file a bug.

David

@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Dec 10, 2021

hmmm, I thought we had taken care of that test. I will investigate

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler core-libs hotspot-jfr integrated javadoc kulla net serviceability
3 participants