Skip to content
This repository has been archived by the owner. It is now read-only.

8278627: Shenandoah: TestHeapDump test failed #56

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Dec 21, 2021

This intermittent failure seems to be observed only on Linux ppc64le, but it is not ppc specific problem.

With concurrent thread stack scanning/updating, nmtehod entry barrier has to be applied prior to thread stack/code roots scanning during heap iteration, to ensure scanner only sees to-space objects.

The patch also cleanup the use of nmethod::oops_do_marking_prologue/epilogue(), which should be used with nmethod::oops_do_try_claim() and closures that use the nmethod, e.g. MarkingCodeBlobClosure. Since Shenandoah switched to concurrent code root iteration, they are no longer applied.

Test:
The failure on Linux ppc64le is intermittent, usually sees a failure about 3 hotspot_gc_shenandoah runs. I have yet seen any failures after 10 runs with the patch.

SAP tested this patch in jdk/jdk repo in nightly tests, did not see failure so far.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/56/head:pull/56
$ git checkout pull/56

Update a local copy of the PR:
$ git checkout pull/56
$ git pull https://git.openjdk.java.net/jdk18 pull/56/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 56

View PR using the GUI difftool:
$ git pr show -t 56

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/56.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 21, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Dec 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 21, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278627: Shenandoah: TestHeapDump test failed

Reviewed-by: shade, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 54517fa: 8279074: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macosx-aarch64
  • ac7430c: 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases.
  • db3d6d7: 8278087: Deserialization filter and filter factory property error reporting under specified

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 21, 2021
@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Dec 21, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

Going to push as commit 1128674.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 54517fa: 8279074: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macosx-aarch64
  • ac7430c: 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases.
  • db3d6d7: 8278087: Deserialization filter and filter factory property error reporting under specified

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 21, 2021
@openjdk openjdk bot closed this Dec 21, 2021
@openjdk openjdk bot removed ready rfr labels Dec 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

@zhengyu123 Pushed as commit 1128674.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-gc integrated shenandoah
3 participants