8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d

[coleenp]

This is the fix for openjdk/jdk#6900 retargeted to JDK 18.

Thanks to @stefank and @fisk for the diagnosis. ZGC is looking at metadata in unloaded nmethods, but redefinition doesn't keep this metadata from being deallocated. Change the iterators that mark metadata in use to walk unloaded nmethods as well as other alive nmethods.

The test case reproduces the crash on windows if run in an 100 iteration loop. This fix does not crash in the same test. Also ran tier1-6.

Above testing in progress.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)
• Erik Österlund - Reviewer ⚠️ Added manually

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/63/head:pull/63
$ git checkout pull/63

Update a local copy of the PR:
$ git checkout pull/63
$ git pull https://git.openjdk.java.net/jdk18 pull/63/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 63

View PR using the GUI difftool:
$ git pr show -t 63

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/63.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9e9487a1)

[coleenp]

/label add hotspot
/label remove hotspot-compiler
/label add serviceability

[openjdk]

@coleenp
The hotspot label was successfully added.

[openjdk]

@coleenp
The hotspot-compiler label was successfully removed.

[openjdk]

@coleenp
The serviceability label was successfully added.

[vnkozlov]

okay

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d

Reviewed-by: kvn, sspitsyn, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• dfb15c3: 8274315: JFR: One closed state per file or stream
• e49d4a9: 8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters
• 713fbeb: 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in write_sample_info
• 7341439: 8279007: jstatd fails to start because SecurityManager is disabled
• 97c5cd7: 8278508: Enable X86 maskAll instruction pattern for 32 bit JVM.
• 9ee3ccf: 8279045: Intrinsics missing vzeroupper instruction
• 84d3333: 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

/reviewer add fisk

[openjdk]

@coleenp Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

• /reviewer credit @openjdk-bot
• /reviewer credit duke
• /reviewer credit @user1 @user2

[coleenp]

/reviewer credit @fisk

@fisk reviewed the JDK 19 version which is the same change as this.

[openjdk]

@coleenp Could not parse fisk as a valid reviewer.
Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

• /reviewer credit @openjdk-bot
• /reviewer credit duke
• /reviewer credit @user1 @user2

[coleenp]

Thanks for reviewing, Vladimir and Serguei.

[coleenp]

/reviewer credit @fisk

trying again.

[openjdk]

@coleenp
Reviewer eosterlund successfully credited.

[coleenp]

/integrate

[openjdk]

Going to push as commit 2be3e7e.
Since your change was applied there have been 7 commits pushed to the master branch:

• dfb15c3: 8274315: JFR: One closed state per file or stream
• e49d4a9: 8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters
• 713fbeb: 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in write_sample_info
• 7341439: 8279007: jstatd fails to start because SecurityManager is disabled
• 97c5cd7: 8278508: Enable X86 maskAll instruction pattern for 32 bit JVM.
• 9ee3ccf: 8279045: Intrinsics missing vzeroupper instruction
• 84d3333: 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 2be3e7e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.