Skip to content
This repository has been archived by the owner. It is now read-only.

8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters #64

Closed
wants to merge 2 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Dec 22, 2021

Hi,

On arabic locales, the filename of a repository file may become invalid.

Fix is to format the filename using a StringBuilder instead of using String.format("%s_%02d%s", filename, counter, FILE_EXTENSION). A similar problem exists when using 'jfr disassemble ', but it is much more unlikely to happen, so it will be fixed separately for JDK 19.

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/64/head:pull/64
$ git checkout pull/64

Update a local copy of the PR:
$ git checkout pull/64
$ git pull https://git.openjdk.java.net/jdk18 pull/64/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 64

View PR using the GUI difftool:
$ git pr show -t 64

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/64.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 22, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr label Dec 22, 2021
@egahlin egahlin marked this pull request as ready for review Dec 22, 2021
@openjdk openjdk bot added the rfr label Dec 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 22, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 7341439: 8279007: jstatd fails to start because SecurityManager is disabled
  • 97c5cd7: 8278508: Enable X86 maskAll instruction pattern for 32 bit JVM.
  • 9ee3ccf: 8279045: Intrinsics missing vzeroupper instruction

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 22, 2021
@egahlin
Copy link
Member Author

@egahlin egahlin commented Dec 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

Going to push as commit e49d4a9.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 713fbeb: 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in write_sample_info
  • 7341439: 8279007: jstatd fails to start because SecurityManager is disabled
  • 97c5cd7: 8278508: Enable X86 maskAll instruction pattern for 32 bit JVM.
  • 9ee3ccf: 8279045: Intrinsics missing vzeroupper instruction

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 22, 2021
@openjdk openjdk bot closed this Dec 22, 2021
@openjdk openjdk bot removed ready rfr labels Dec 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

@egahlin Pushed as commit e49d4a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-jfr integrated
2 participants